Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unremovable bottom padding when using line-height #449

Open
keturiosakys opened this issue Feb 5, 2024 · 10 comments · May be fixed by #851
Open

Unremovable bottom padding when using line-height #449

keturiosakys opened this issue Feb 5, 2024 · 10 comments · May be fixed by #851

Comments

@keturiosakys
Copy link

I've set the line height property to 1.2 and it seems that all terminal rendering now has this bottom padding (see screenshot):

line-height = 1.2
CleanShot 2024-02-05 at 17 24 12@2x
@Artemis21
Copy link

Artemis21 commented Feb 7, 2024

I have a similar issue. For me, the padding appears above the tab list (with navigation.mode = "BottomTab").

image

Full config
editor = 'vim'
cursor = ''
blinking-cursor = false
theme = 'onedark'
padding-x = 10
line-height = 1.2

[window]
mode = "Maximized"

[fonts]
family = "FiraCode Nerd Font Mono"
size = 19

[scroll]
multiplier = 5.0
divider = 1.0

[navigation]
mode = "TopTab"
clickable = true

@taggon
Copy link

taggon commented Feb 8, 2024

Same here. Also the viewport overflows when you set the line height to a value less than 1.

@raphamorim
Copy link
Owner

Thanks for the issue!

Yea, currently line-height property is quite unstable, I am fixing it in #428 (which will add some text rendering features as well).

@ehamiter
Copy link

Hi @raphamorim -- looks like #428 was merged but seems the padding is still an issue?

@raphamorim
Copy link
Owner

Yes, it is still an issue. Will be looking it for the upcoming versions (probably next one), sorry about delay!

@kristoferlund
Copy link

@raphamorim Just started using Rio the other day, feels like a great terminal! The ability to adjust the line height is the only thing I am missing so far.

@raphamorim
Copy link
Owner

Ok, fyi: I will finally look on this for v0.2.0 (next version)

@doongjohn
Copy link

The line-height option is not working in 0.2.1. Is the value fixed to 1.0 for now?

@raphamorim
Copy link
Owner

No 😢 sorry peeps, I had to cut release earlier. I am looking this and #124

@raphamorim raphamorim moved this to In Progress in Rio terminal 0.2.x Dec 9, 2024
@raphamorim raphamorim linked a pull request Dec 17, 2024 that will close this issue
@mantacid
Copy link

this issue can be triggered by certain fonts, even when using the default value for line height. Rio's default font doesn't trigger this behavior, but a font like unscii will cause this same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

8 participants