-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unremovable bottom padding when using line-height #449
Comments
I have a similar issue. For me, the padding appears above the tab list (with Full configeditor = 'vim'
cursor = '▇'
blinking-cursor = false
theme = 'onedark'
padding-x = 10
line-height = 1.2
[window]
mode = "Maximized"
[fonts]
family = "FiraCode Nerd Font Mono"
size = 19
[scroll]
multiplier = 5.0
divider = 1.0
[navigation]
mode = "TopTab"
clickable = true |
Same here. Also the viewport overflows when you set the line height to a value less than 1. |
Thanks for the issue! Yea, currently line-height property is quite unstable, I am fixing it in #428 (which will add some text rendering features as well). |
Hi @raphamorim -- looks like #428 was merged but seems the padding is still an issue? |
Yes, it is still an issue. Will be looking it for the upcoming versions (probably next one), sorry about delay! |
@raphamorim Just started using Rio the other day, feels like a great terminal! The ability to adjust the line height is the only thing I am missing so far. |
Ok, fyi: I will finally look on this for v0.2.0 (next version) |
The line-height option is not working in 0.2.1. Is the value fixed to 1.0 for now? |
No 😢 sorry peeps, I had to cut release earlier. I am looking this and #124 |
this issue can be triggered by certain fonts, even when using the default value for line height. Rio's default font doesn't trigger this behavior, but a font like unscii will cause this same issue. |
I've set the line height property to
1.2
and it seems that all terminal rendering now has this bottom padding (see screenshot):The text was updated successfully, but these errors were encountered: