added stats accumulation to getHash endpoit, added comments to README

Author: randith

README.md

@@ -1,6 +1,24 @@
 # goexample
 
-## getting started
+## notes
+1. I included a build script to make a docker container from the PoC I did recently.  It is very early in development but a good first step to a real ci/cd build of a go service.  It is not complete, missing among other things versioning."
+2. I started running short on time so I did not add tests for 4-6.  I would add these as well as a round-trip test using the endpoints.
+3. I interpreted step 6 "hash requests" to include creating and getting the hashes
+4. I left TODO comments in the code to shed light on my thoughts.  I do not like leaving them in the code normally as they grow stale fast.
+
+## running
+1. prerequisites
+  * docker
+  * this repository installed properly in the GOPATH
+  * being in the root directory of this repository 
+2. execute build script
+  * ```./build.sh```
+3. run container
+  * ```docker run -p 8080:8080 pwhash```
+
+## developing
+
+### setting up go environment
 
 1. install go and dep
   * ```brew install go dep```
@@ -15,9 +33,8 @@
 3. get this service 
   * ```go get github.com/randith/goexample```
 
-## developing
-
 ### add or update dependencies
+Of course there are none yet since only using standard libraries
 
 * ```dep ensure```
 * commit and push dependencies

cmd/pwhash/main.go

@@ -23,7 +23,7 @@ func startHttpServer(store pwhash.Store, statsStore pwhash.Stats) *http.Server {
 	srv := &http.Server{Addr: ":8080"}
 
 	http.Handle("/hash", pwhash.PostHashHandler(store, statsStore))
-	http.Handle("/hash/", pwhash.GetHashHandler(store))
+	http.Handle("/hash/", pwhash.GetHashHandler(store, statsStore))
 	http.Handle("/shutdown", pwhash.PostShutdownHandler(srv))
 	http.Handle("/stats", pwhash.GetStatsHandler(statsStore))
 

pkg/pwhash/getHash.go

@@ -8,7 +8,7 @@ import (
 	"time"
 )
 
-func GetHashHandler(store Store) http.Handler {
+func GetHashHandler(store Store, stats Stats) http.Handler {
 	return http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
 		start := time.Now()
 		if req.Method != "GET" {
@@ -34,6 +34,8 @@ func GetHashHandler(store Store) http.Handler {
 		rw.Header().Set("Content-Type", "text/plain")
 		io.WriteString(rw, hash)
 
-		log.Printf("GetHashHandler complete in %s", time.Now().Sub(start))
+		duration := time.Now().Sub(start)
+		stats.Time(duration.Nanoseconds() / int64(time.Millisecond))
+		log.Printf("GetHashHandler complete in %s", duration)
 	})
 }