Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete related attachment & images when an entity is deleted #399

Open
joelvdavies opened this issue Oct 22, 2024 · 0 comments · May be fixed by #460
Open

Delete related attachment & images when an entity is deleted #399

joelvdavies opened this issue Oct 22, 2024 · 0 comments · May be fixed by #460
Assignees
@VKTB
Labels
enhancement New feature or request

Comments

@joelvdavies
Copy link
Collaborator

joelvdavies commented Oct 22, 2024 •
edited by VKTB
Loading

When a catalogue item, item or system is deleted. Any attachments/images should also be deleted. This relies on

I think the simplest method for authentication is to ensure that on the delete request ims-api does the following:

  • Send a request to delete all related entity data using the same jwt token and wait for the response and then
    • If successful: Delete the entity
    • If authentication fails producing a 403: Replicate the same error so the front end does the token refresh
    • If any other error occurs or a response times out: Raise an appropriate error - Will likely need additional logic to prevent existing tests from failing due to not being able to contact the object-storage-api.

Further considerations

  • May require integration tests
@joelvdavies joelvdavies added the enhancement New feature or request label Oct 22, 2024
@joelvdavies joelvdavies changed the title Delete related attachment & image files when an entity is deleted Delete related attachment & images when an entity is deleted Oct 22, 2024
@joelvdavies joelvdavies mentioned this issue Oct 28, 2024
Merged
3 tasks
@joelvdavies joelvdavies self-assigned this Jan 13, 2025
@joelvdavies joelvdavies moved this from Backlog to In Progress in Inventory Management System Jan 13, 2025
@joelvdavies joelvdavies moved this from In Progress to Up Next in Inventory Management System Jan 13, 2025
@joelvdavies joelvdavies assigned VKTB and unassigned joelvdavies Jan 13, 2025
@VKTB VKTB moved this from Up Next to To Do On This Sprint in Inventory Management System Jan 29, 2025
@VKTB VKTB moved this from To Do On This Sprint to In Progress in Inventory Management System Feb 12, 2025
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Update config to include Object Storage related values #399
5fd053a
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Create custom Object Storage API exceptions #399
0612f1e
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Implement a client class for interacting with Object Storage API #399
9190ba9
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Write unit tests for ObjectStorageAPIClient class #399
47135b5
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Delete all associated objects when catalogue item deleted #399
b0d40f3
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Delete all associated objects when item deleted #399
755d723
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Delete all associated objects when system deleted #399
fefb5f9
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Update README #399
f19be81
@VKTB VKTB linked a pull request Feb 13, 2025 that will close this issue
Open
5 tasks
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Add requests dependency #399
13f69f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VKTB VKTB

Labels
enhancement New feature or request
Projects
Inventory Management System
Status: In Progress
Milestone
No milestone
2 participants
@VKTB @joelvdavies