improve error handling

Author: leonid-shevtsov

aws/aws_param_store.go

@@ -72,7 +72,17 @@ func LoadConfigFromParameterStore(session *session.Session, paramPrefix string,
 }
 
 func writeParamToConfig(config interface{}, name string, value string) global.Error {
-	destination := reflect.ValueOf(config).Elem()
+	destination := reflect.ValueOf(config)
+
+	if destination.Kind() == reflect.Ptr {
+		return global.NewError("config must be a pointer to a structure")
+	}
+
+	destination = destination.Elem()
+
+	if destination.Kind() == reflect.Struct {
+		return global.NewError("config must be a pointer to a structure")
+	}
 
 	// find nested field in config struct
 	pathParts := strings.Split(name, paramStoreSeparator)

error.go

@@ -21,9 +21,9 @@ func (g globalError) Warning() bool {
 }
 
 func NewWarning(msg string, arguments ...interface{}) Error {
-	return globalError{fmt.Sprintf(msg, arguments...), true}
+	return &globalError{fmt.Sprintf(msg, arguments...), true}
 }
 
 func NewError(msg string, arguments ...interface{}) Error {
-	return globalError{fmt.Sprintf(msg, arguments...), false}
+	return &globalError{fmt.Sprintf(msg, arguments...), false}
 }