Skip to content

Commit ac09857

Browse files
authored
Merge pull request #87 from rails/rm-NOTES
Add NOTES.md files to all features
2 parents d80e37d + c601ab5 commit ac09857

File tree

15 files changed

+37
-12
lines changed

15 files changed

+37
-12
lines changed

features/src/activestorage/NOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
## OS Support
2+
3+
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.

features/src/activestorage/README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,3 @@ Installs libvips, ffmpeg and poppler-utils which are required to use Active Stor
2020

2121
### VS Code Extensions
2222

23-
## OS Support
24-
25-
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.
26-
27-
`bash` is required to execute the `install.sh` script.

features/src/activestorage/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"id": "activestorage",
33
"version": "1.1.1",
44
"name": "Active Storage",
5-
"description": "Installs utilities needed for Rails Active Storage",
5+
"description": "Installs libvips, ffmpeg and poppler-utils which are required to use Active Storage for Rails apps.",
66
"options": {
77
"variantProcessor": {
88
"type": "string",

features/src/bun/NOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
## OS Support
2+
3+
This Feature should work on recent versions of Debian/Ubuntu-based distributions.

features/src/bun/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"id": "bun",
33
"version": "1.0.2",
44
"name": "Bun",
5-
"description": "Installs needed client-side dependencies for Rails apps using Bun"
5+
"description": "Installs needed client-side dependencies for Rails apps using Bun."
66
}

features/src/bundler-cache/NOTES.md

Whitespace-only changes.

features/src/bundler-cache/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"id": "bundler-cache",
33
"version": "1.0.1",
44
"name": "Bundler cache",
5-
"description": "Creates a volume for persisting the installed gems across different containers",
5+
"description": "Creates a volume for persisting the installed gems across different containers.",
66
"containerEnv": {
77
"BUNDLE_PATH": "/bundle/vendor"
88
},

features/src/mysql-client/NOTES.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
## OS Support
2+
3+
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.
4+
5+
## Notes
6+
7+
NOTE: This feature does not install the dependencies needed for the MySQL Server. For that we
8+
recommend running a service using the official
9+
[MySQL docker image](https://hub.docker.com/_/mysql).

features/src/mysql-client/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"id": "mysql-client",
33
"version": "1.1.1",
44
"name": "MySQL Client",
5-
"description": "Installs needed client-side dependencies for Rails apps using MySQL"
5+
"description": "Installs needed client-side dependencies for Rails apps using MySQL."
66
}

features/src/postgres-client/NOTES.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
## OS Support
2+
3+
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.
4+
5+
## Notes
6+
7+
NOTE: This feature does not install the dependencies needed for the Postgres server.
8+
For that we recommend running a service using the official
9+
[Postgres docker image](https://hub.docker.com/_/postgres).

features/src/postgres-client/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"id": "postgres-client",
33
"version": "1.1.3",
44
"name": "Postgres Client",
5-
"description": "Installs needed client-side dependencies for Rails apps using Postgres",
5+
"description": "Installs needed client-side dependencies for Rails apps using Postgres.",
66
"options": {
77
"version": {
88
"type": "string",

features/src/ruby/NOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
## OS Support
2+
3+
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.

features/src/ruby/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"id": "ruby",
33
"version": "1.1.3",
44
"name": "Ruby (via rbenv)",
5-
"description": "Installs Ruby, rbenv, ruby-build and libraries needed to build Ruby",
5+
"description": "Installs Ruby, rbenv, and ruby-build as well as the dependencies needed to build Ruby.",
66
"customizations": {
77
"vscode": {
88
"extensions": [

features/src/sqlite3/NOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
## OS Support
2+
3+
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.

features/src/sqlite3/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"id": "sqlite3",
33
"version": "1.0.0",
44
"name": "SQLite3",
5-
"description": "Installs needed dependencies for Rails apps using SQLite3"
5+
"description": "Installs needed dependencies for Rails apps using SQLite3."
66
}

0 commit comments

Comments
 (0)