Concurrent uploading in mirror services

Author: SGospodinov

lib/active_storage/service/mirror_service.rb

@@ -18,9 +18,7 @@ def initialize(primary:, mirrors:)
   end
 
   def upload(key, io, checksum: nil)
-    each_service.collect do |service|
-      service.upload key, io.tap(&:rewind), checksum: checksum
-    end
+    perform_across_services :upload, key, io.tap(&:rewind), checksum: checksum
   end
 
   def delete(key)
@@ -33,9 +31,9 @@ def each_service(&block)
     end
 
     def perform_across_services(method, *args)
-      promises = services.collect do |service|
+      promises = each_service.collect do |service|
         Concurrent::Promise.execute { service.public_send method, *args }
       end
-      Concurrent::Promise.zip(*promises).value
+      Concurrent::Promise.zip(*promises).value!
     end
 end