Support installation of SQL Express 2017

andyundso · andyundso · commit 1149cc8cc77f · 2024-07-27T16:09:12.000+02:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,14 +14,16 @@ jobs:
       matrix:
         os:
           # ignore ARM64 flavours
-          - macos-12-large
-          - macos-13-large
-          - macos-14-large
           - ubuntu-20.04
           - ubuntu-22.04
           - ubuntu-24.04
           - windows-2019
           - windows-2022
+        version:
+          - 2017
+        exclude:
+          - os: ubuntu-24.04
+            version: 2017
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -36,9 +38,13 @@ jobs:
       - name: Run Action
         uses: ./action
         with:
-          components: sqlcmd
+          components: sqlcmd,sqlengine
+          sa-password: "bHuZH81%cGC6"
+          version: ${{ matrix.version }}
 
       - name: Run tests
         run: |
           action/test.ps1
         shell: pwsh
+        env:
+          SA_PASSWORD: "bHuZH81%cGC6"
diff --git a/action.yml b/action.yml
@@ -7,13 +7,23 @@ inputs:
   components:
     description: "The components to install"
     required: true
+  sa-password:
+    description: "The SA password for the SQL instance"
+    required: true
+  version:
+    description: "The version of the SQL instance"
+    required: true
 runs:
   using: "composite"
   steps:
     - shell: pwsh
       run: |
         $params = @{
             Components = ("${{ inputs.components }}" -split ",").Trim()
+            SaPassword = "${{ inputs.sa-password }}"
+            Version = "${{ inputs.version }}"
         }
 
         ${{ github.action_path }}/install.ps1 @params
+      env:
+        HOMEBREW_NO_AUTO_UPDATE: "1"
diff --git a/install.ps1 b/install.ps1
@@ -1,29 +1,113 @@
 param (
-    [ValidateSet("sqlcmd")]
-    [string[]]$Components
+    [ValidateSet("sqlcmd", "sqlengine")]
+    [string[]]$Components,
+    [string]$SaPassword,
+    [ValidateSet("2017")]
+    [string]$Version
 )
 
-if ("sqlcmd" -in $Components) {
-    if ($IsMacOS) {
-        Write-Output "Installing sqlcmd tools"
-        brew install sqlcmd
+function Wait-ForContainer {
+    $checkInterval = 5
+    $containerName = "sql"
+    $timeout = 120
+
+    $startTime = Get-Date
+    Write-Host "Waiting for the container '$containerName' to be healthy..."
+
+    while ($true) {
+        # Get the container's health status
+        $healthStatus = (docker inspect --format='{{.State.Health.Status}}' $containerName) 2>&1
+
+        if ($healthStatus -eq "healthy") {
+            Write-Host "Container '$containerName' is healthy."
+            break
+        }
+        elseif ((Get-Date) -gt $startTime.AddSeconds($timeout)) {
+            Write-Host "Timed out waiting for container '$containerName' to be healthy."
+            & docker logs sql
+            exit 1
+        }
+
+        # Wait for the check interval before checking again
+        Start-Sleep -Seconds $checkInterval
     }
+}
+
+# figure out if we are running Ubuntu 24.04, as we need to implement a couple of custom behaviours for it
+$IsUbuntu2404 = $false
+if ($IsLinux) {
+    $osRelease = Get-Content -Path "/etc/os-release" | Out-String
+    $osRelease -match 'VERSION_ID="(\d+\.\d+)"' | Out-Null
+    $IsUbuntu2404 = $matches[1] -eq "24.04"
+}
 
+if ("sqlengine" -in $Components) {
     if ($IsLinux) {
-        $osRelease = Get-Content -Path "/etc/os-release" | Out-String
-        $osRelease -match 'VERSION_ID="(\d+\.\d+)"' | Out-Null
-        $version = $matches[1]
-
-        if ($version -eq "24.04") {
-            # for maintenance reasons, sqlcmd has been removed from the runner image
-            # but a dedicated build is also not yet available, so we are using the Ubuntu 22.04 build
-            Write-Output "Installing sqlcmd tools"
-
-            $DownloadPath = "/tmp/sqlcmd.deb"
-            Invoke-WebRequest "https://packages.microsoft.com/ubuntu/22.04/prod/pool/main/s/sqlcmd/sqlcmd_1.5.0-1_jammy_all.deb" -OutFile $DownloadPath
-            & sudo dpkg -i $DownloadPath
-            Remove-Item $DownloadPath
+        # the Ubuntu 24.04 image uses a kernel version which does not work with the current 2017 version.
+        # see https://github.com/microsoft/mssql-docker/issues/868
+
+        # but also manual installation is difficult since MSSQL has been released for Ubuntu 18.04 only
+        # you could backport all of this somehow, but 2017 is EOL soon anyhow
+        # $ apt install --fix-broken -y ./mssql-server_14.0.3465.1-1_amd64.deb 
+        # Reading package lists... Done
+        # Building dependency tree... Done
+        # Reading state information... Done
+        # Correcting dependencies... Done
+        # Note, selecting 'mssql-server' instead of './mssql-server_14.0.3465.1-1_amd64.deb'
+        # mssql-server is already the newest version (14.0.3465.1-1).
+        # Some packages could not be installed. This may mean that you have
+        # requested an impossible situation or if you are using the unstable
+        # distribution that some required packages have not yet been created
+        # or been moved out of Incoming.
+        # The following information may help to resolve the situation:
+
+        # The following packages have unmet dependencies:
+        #  mssql-server : Depends: libjemalloc1 but it is not installable
+        #                 Depends: libssl1.0.0 but it is not installable
+        #                 Depends: python (>= 2.7.0) but it is not installable
+        #                 Depends: libldap-2.4-2 but it is not installable
+        # E: Unable to correct problems, you have held broken packages.
+        if ($IsUbuntu2404) {
+            Write-Error "MSSQL 2017 is not available on Ubuntu 24.04."
+            Write-Error "See more information at https://github.com/microsoft/mssql-docker/issues/868"
+            exit 1
         }
+
+        Write-Output "Starting a Docker Container"
+        Invoke-Expression "docker run --name=`"sql`" -e `"ACCEPT_EULA=Y`"-e `"SA_PASSWORD=$SaPassword`" -e `"MSSQL_PID=Express`" --health-cmd=`"/opt/mssql-tools/bin/sqlcmd -C -S localhost -U sa -P '$SaPassword' -Q 'SELECT 1' -b -o /dev/null`" --health-start-period=`"10s`" --health-retries=3 --health-interval=`"10s`" -p 1433:1433 -d `"mcr.microsoft.com/mssql/server:$Version-latest`""
+        Wait-ForContainer
+    }
+
+    if ($IsWindows) {
+        Write-Output "Downloading and installing SQL Server"
+        New-Item -ItemType Directory -Path "C:\Downloads"
+
+        Invoke-WebRequest "https://download.microsoft.com/download/E/F/2/EF23C21D-7860-4F05-88CE-39AA114B014B/SQLEXPR_x64_ENU.exe" -OutFile "C:\Downloads\mssql.exe"
+        Start-Process -Wait -FilePath "C:\Downloads\mssql.exe" -ArgumentList /qs, /x:"C:\Downloads\setup"
+        C:\Downloads\setup\setup.exe /q /ACTION=Install /INSTANCENAME=SQLEXPRESS /FEATURES=SQLEngine /UPDATEENABLED=0 /SQLSVCACCOUNT='NT AUTHORITY\System' /SQLSYSADMINACCOUNTS='BUILTIN\ADMINISTRATORS' /TCPENABLED=1 /NPENABLED=0 /IACCEPTSQLSERVERLICENSETERMS
+
+        Write-Host "Configuring SQL Express ..."
+        stop-service MSSQL`$SQLEXPRESS
+        set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpdynamicports -value ''
+        set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\supersocketnetlib\tcp\ipall' -name tcpport -value 1433
+        set-itemproperty -path 'HKLM:\software\microsoft\microsoft sql server\mssql14.SQLEXPRESS\mssqlserver\' -name LoginMode -value 2
+
+        Write-Host "Starting SQL Express ..."
+        start-service MSSQL`$SQLEXPRESS
+        & sqlcmd -Q "ALTER LOGIN sa with password='$SaPassword'; ALTER LOGIN sa ENABLE;"
+    }
+}
+
+if ("sqlcmd" -in $Components) {
+    if ($IsUbuntu2404) {
+        # for maintenance reasons, sqlcmd has been removed from the Ubuntu 24.04 runner image
+        # but a dedicated build is also not yet available, so we are using the Ubuntu 22.04 build
+        Write-Output "Installing sqlcmd tools"
+
+        $DownloadPath = "/tmp/sqlcmd.deb"
+        Invoke-WebRequest "https://packages.microsoft.com/ubuntu/22.04/prod/pool/main/s/sqlcmd/sqlcmd_1.5.0-1_jammy_all.deb" -OutFile $DownloadPath
+        & sudo dpkg -i $DownloadPath
+        Remove-Item $DownloadPath
     }
 
     # Linux and Windows runner already contain sqlclient tools
diff --git a/test.ps1 b/test.ps1
@@ -1,6 +1,10 @@
 if (Get-Command sqlcmd -ErrorAction SilentlyContinue) {
     Write-Output "sqlcmd command exists."
-} else {
+}
+else {
     Write-Output "sqlcmd command does not exist."
     exit 1
 }
+
+Write-Output "Checking if SQL Server is available ..."
+& sqlcmd -S 127.0.0.1 -U sa -P $env:SA_PASSWORD -Q "SELECT 1"
