From ef1779463f8a9e08e4a039ef694fedaa97a0aa0c Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:49 +0000 Subject: [PATCH 1/8] Fix 3 occurrences of `send-chain-to-send+` This method chain made of nested `send` expressions can be written more clearly as a `send+` expression. --- .../tests/drracket/no-write-and-frame-leak.rkt | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt index 65a80734a..31cdf6be2 100644 --- a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt +++ b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt @@ -63,8 +63,10 @@ This test checks: (sync (system-idle-evt)) (define drs-tabb (make-weak-box (send drs-frame1 get-current-tab))) - (define tab-nsb (make-weak-box (send (send (send drs-frame1 get-current-tab) get-ints) - get-user-namespace))) + (define tab-nsb (make-weak-box (send+ drs-frame1 + (get-current-tab) + (get-ints) + (get-user-namespace)))) (test:menu-select "File" (if (eq? (system-type) 'unix) "Close" "Close Tab")) (sync (system-idle-evt)) @@ -74,12 +76,16 @@ This test checks: (define drs-frame2b (make-weak-box (wait-for-new-frame drs-frame1))) (define frame2-nsb (make-weak-box - (send (send (send (weak-box-value drs-frame2b) get-current-tab) get-ints) - get-user-namespace))) + (send+ (weak-box-value drs-frame2b) + (get-current-tab) + (get-ints) + (get-user-namespace)))) (queue-callback/res - (λ () (send (send (send (weak-box-value drs-frame2b) get-current-tab) get-defs) load-file - (collection-file-path "rep.rkt" "drracket" "private")))) + (λ () (send+ (weak-box-value drs-frame2b) + (get-current-tab) + (get-defs) + (load-file (collection-file-path "rep.rkt" "drracket" "private"))))) (sleep 2) (extra-waiting (weak-box-value drs-frame2b)) (sync (system-idle-evt)) From 047f2e7030ac12869accddd6dcf6a7c102e34a04 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:49 +0000 Subject: [PATCH 2/8] Fix 1 occurrence of `hash-set!-ref-to-hash-update!` This expression can be replaced with a simpler, equivalent `hash-update!` expression. --- drracket-test/tests/drracket/no-write-and-frame-leak.rkt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt index 31cdf6be2..d1625cfa8 100644 --- a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt +++ b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt @@ -145,10 +145,7 @@ This test checks: string<=? #:key symbol->string) (list (send item get-shortcut)))) - (hash-set! shortcuts - k - (cons (send item get-label) - (hash-ref shortcuts k '())))))) + (hash-update! shortcuts k (λ (v) (cons (send item get-label) v)) '())))) (define (get-lab item) (cond From 7e7f12ca00a6ff49144267ed5b6b3db62786137f Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:49 +0000 Subject: [PATCH 3/8] Fix 1 occurrence of `unless-expression-in-for-loop-to-unless-keyword` Use the `#:unless` keyword instead of `unless` to reduce loop body indentation. --- drracket-test/tests/drracket/no-write-and-frame-leak.rkt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt index d1625cfa8..167235d81 100644 --- a/drracket-test/tests/drracket/no-write-and-frame-leak.rkt +++ b/drracket-test/tests/drracket/no-write-and-frame-leak.rkt @@ -165,10 +165,9 @@ This test checks: '()]))) (define (check-shortcuts) - (for ([(k v) (in-hash shortcuts)]) - (unless (= 1 (length v)) - (eprintf "found multiple menu items with the shortcut ~s: ~s\n" - k v)))) + (for ([(k v) (in-hash shortcuts)] + #:unless (= 1 (length v))) + (eprintf "found multiple menu items with the shortcut ~s: ~s\n" k v))) (process-container (send frame get-menu-bar)) (check-shortcuts)) From 0a3343cde047880820f9c066a35afa05d7d9cec3 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:50 +0000 Subject: [PATCH 4/8] Fix 1 occurrence of `hash-for-each-to-for` This `hash-for-each` operation can be replaced with a `for` loop. --- .../private/standalone-module-browser.rkt | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drracket-tool-lib/drracket/private/standalone-module-browser.rkt b/drracket-tool-lib/drracket/private/standalone-module-browser.rkt index ce7bdb865..5d34d2b30 100644 --- a/drracket-tool-lib/drracket/private/standalone-module-browser.rkt +++ b/drracket-tool-lib/drracket/private/standalone-module-browser.rkt @@ -1027,13 +1027,14 @@ ;; major-dim is the dimension that new levels extend along ;; minor-dim is the dimension that snips inside a level extend along - (hash-for-each - level-ht - (λ (n v) - (set! max-minor (max max-minor (apply + (map (if vertical? - (λ (x) (get-snip-width x)) - (λ (x) (get-snip-height x))) - v)))))) + (for ([(n v) (in-hash level-ht)]) + (set! max-minor + (max max-minor + (apply + + (map (if vertical? + (λ (x) (get-snip-width x)) + (λ (x) (get-snip-height x))) + v))))) (define levels (sort (hash-map level-ht list) <= #:key car)) (let loop ([levels levels] From 0fbf8551a13870f5dd6ed7e9d666a70c91b1c048 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:50 +0000 Subject: [PATCH 5/8] Fix 2 occurrences of `if-let-to-cond` `cond` with internal definitions is preferred over `if` with `let`, to reduce nesting --- .../private/standalone-module-browser.rkt | 35 ++++++++++--------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drracket-tool-lib/drracket/private/standalone-module-browser.rkt b/drracket-tool-lib/drracket/private/standalone-module-browser.rkt index 5d34d2b30..807be068e 100644 --- a/drracket-tool-lib/drracket/private/standalone-module-browser.rkt +++ b/drracket-tool-lib/drracket/private/standalone-module-browser.rkt @@ -1264,15 +1264,15 @@ (if m (cadr m) word)) - (if (string=? short-name "") - "" - (let ([ms (regexp-match* #rx"-[^-]*" short-name)]) - (cond - [(null? ms) (substring short-name 0 (min 2 (string-length short-name)))] - [else - (apply string-append - (cons (substring short-name 0 1) - (map (λ (x) (substring x 1 2)) ms)))])))] + (cond + [(string=? short-name "") ""] + [else + (define ms (regexp-match* #rx"-[^-]*" short-name)) + (cond + [(null? ms) (substring short-name 0 (min 2 (string-length short-name)))] + [else + (apply string-append + (cons (substring short-name 0 1) (map (λ (x) (substring x 1 2)) ms)))])])] [(long) word] [(very-long) (string-append word ": " (format "~s" require-phases))])) last-name])) @@ -1351,14 +1351,15 @@ (λ (filename) (define p (open-input-file filename)) (define wxme? (regexp-match-peek #rx#"^WXME" p)) - (if wxme? - (let ([t (new text%)]) - (close-input-port p) - (send t load-file filename) - (let ([prt (open-input-text-editor t)]) - (port-count-lines! prt) - prt)) - p))) + (cond + [wxme? + (define t (new text%)) + (close-input-port p) + (send t load-file filename) + (define prt (open-input-text-editor t)) + (port-count-lines! prt) + prt] + [else p]))) (current-load-relative-directory #f) (define relative? (eq? init-dir 'relative)) (unless relative? ; already there From ba62c4fb5ad42c59236c2e06a1ffa6004eb47daf Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:50 +0000 Subject: [PATCH 6/8] Fix 10 occurrences of `let-to-define` Internal definitions are recommended instead of `let` expressions, to reduce nesting. --- .../tests/drracket/language-test.rkt | 160 +++++++++--------- .../tests/drracket/syncheck-test.rkt | 117 +++++++------ 2 files changed, 135 insertions(+), 142 deletions(-) diff --git a/drracket-test/tests/drracket/language-test.rkt b/drracket-test/tests/drracket/language-test.rkt index dcb74eaef..f2cb113dc 100644 --- a/drracket-test/tests/drracket/language-test.rkt +++ b/drracket-test/tests/drracket/language-test.rkt @@ -1532,11 +1532,11 @@ the settings above should match r5rs (define (prepare-for-test-expression) - (let ([drs (wait-for-drracket-frame)]) - (clear-definitions drs) - (set-language #t) - (sleep 1) ;; this shouldn't be neccessary.... - (do-execute drs))) + (define drs (wait-for-drracket-frame)) + (clear-definitions drs) + (set-language #t) + (sleep 1) ;; this shouldn't be neccessary.... + (do-execute drs)) ;; test-setting : (-> void) string string string -> void ;; opens the language dialog, runs `set-setting' @@ -1552,34 +1552,37 @@ the settings above should match r5rs (let ([f (test:get-active-top-level-window)]) (fw:test:button-push "OK") (wait-for-new-frame f)) - (let* ([drs (test:get-active-top-level-window)] - [interactions (send drs get-interactions-text)]) - (clear-definitions drs) - (insert-in-definitions drs expression) - (do-execute drs) - (when interactions-expr - (insert-in-interactions drs interactions-expr) - (alt-return-in-interactions drs) - (wait-for-computation drs)) - (let* ([got (fetch-output/should-be-tested drs)]) - (unless (if (regexp? result) - (regexp-match? result got) - (string=? result got)) - (eprintf "FAILED: ~s ~s ~s test\n expected: ~s\n got: ~s\n" - (language) setting-name expression result got))))) + (define drs (test:get-active-top-level-window)) + (send drs get-interactions-text) + (clear-definitions drs) + (insert-in-definitions drs expression) + (do-execute drs) + (when interactions-expr + (insert-in-interactions drs interactions-expr) + (alt-return-in-interactions drs) + (wait-for-computation drs)) + (define got (fetch-output/should-be-tested drs)) + (unless (if (regexp? result) + (regexp-match? result got) + (string=? result got)) + (eprintf "FAILED: ~s ~s ~s test\n expected: ~s\n got: ~s\n" + (language) + setting-name + expression + result + got))) (define (test-hash-bang) - (let* ([expression "#!/bin/sh\n1"] - [result "1"] - [drs (test:get-active-top-level-window)] - [interactions (queue-callback (λ () (send drs get-interactions-text)))]) - (clear-definitions drs) - (insert-in-definitions drs expression) - (do-execute drs) - (let* ([got (fetch-output/should-be-tested drs)]) - (unless (string=? "1" got) - (eprintf "FAILED: ~s ~a test\n expected: ~s\n got: ~s\n" - (language) expression result got))))) + (define expression "#!/bin/sh\n1") + (define result "1") + (define drs (test:get-active-top-level-window)) + (queue-callback (λ () (send drs get-interactions-text))) + (clear-definitions drs) + (insert-in-definitions drs expression) + (do-execute drs) + (define got (fetch-output/should-be-tested drs)) + (unless (string=? "1" got) + (eprintf "FAILED: ~s ~a test\n expected: ~s\n got: ~s\n" (language) expression result got))) (define (fetch-output/should-be-tested . args) (regexp-replace (regexp @@ -1687,9 +1690,9 @@ the settings above should match r5rs (fw:test:set-check-box! "Insert newlines in printed values" pretty?) - (let ([f (test:get-active-top-level-window)]) - (fw:test:button-push "OK") - (wait-for-new-frame f))) + (define f (test:get-active-top-level-window)) + (fw:test:button-push "OK") + (wait-for-new-frame f)) (define (shorten str) (if ((string-length str) . <= . 45) str @@ -1774,15 +1777,14 @@ the settings above should match r5rs (unless (member #\newline (string->list got)) (eprintf "long output should have contained newlines, got ~s\n" got))) - (let () - (clear-definitions drr) - (insert-in-definitions drr (defs-prefix)) - (insert-in-definitions drr "(print-value-columns 1000)") - (insert-in-definitions drr "(build-list 100 values)") - (do-execute drr) - (define got (fetch-output/should-be-tested drr)) - (when (member #\newline (string->list got)) - (eprintf "long output should not have contained newlines, got ~s\n" got))))) + (clear-definitions drr) + (insert-in-definitions drr (defs-prefix)) + (insert-in-definitions drr "(print-value-columns 1000)") + (insert-in-definitions drr "(build-list 100 values)") + (do-execute drr) + (define got (fetch-output/should-be-tested drr)) + (when (member #\newline (string->list got)) + (eprintf "long output should not have contained newlines, got ~s\n" got)))) (define (find-output-radio-box label) (define frame (test:get-active-top-level-window)) @@ -1818,26 +1820,24 @@ the settings above should match r5rs "WARNING: Interactions window is out of sync with the definitions window\\.")) (define (test-error-after-definition) - (let* ([drs (wait-for-drracket-frame)] - [interactions-text (queue-callback/res (λ () (send drs get-interactions-text)))]) - (clear-definitions drs) - (insert-in-definitions drs (defs-prefix)) - (insert-in-definitions drs "(define y 0) (define (f x) (/ x y)) (f 2)") - (do-execute drs) - (let ([last-para (queue-callback/res (λ () (send interactions-text last-paragraph)))]) - (type-in-interactions drs "y\n") - (wait-for-computation drs) - (let ([got - (fetch-output/should-be-tested - drs - (queue-callback/res - (λ () (send interactions-text paragraph-start-position (+ last-para 1)))) - (queue-callback/res - (λ () - (send interactions-text paragraph-end-position - (- (send interactions-text last-paragraph) 1)))))]) - (unless (equal? got "0") - (eprintf "FAILED: test-error-after-definition failed, expected 0, got ~s\n" got)))))) + (define drs (wait-for-drracket-frame)) + (define interactions-text (queue-callback/res (λ () (send drs get-interactions-text)))) + (clear-definitions drs) + (insert-in-definitions drs (defs-prefix)) + (insert-in-definitions drs "(define y 0) (define (f x) (/ x y)) (f 2)") + (do-execute drs) + (define last-para (queue-callback/res (λ () (send interactions-text last-paragraph)))) + (type-in-interactions drs "y\n") + (wait-for-computation drs) + (define got + (fetch-output/should-be-tested + drs + (queue-callback/res (λ () (send interactions-text paragraph-start-position (+ last-para 1)))) + (queue-callback/res (λ () + (send interactions-text paragraph-end-position + (- (send interactions-text last-paragraph) 1)))))) + (unless (equal? got "0") + (eprintf "FAILED: test-error-after-definition failed, expected 0, got ~s\n" got))) ;; test-expression : (union string 'xml 'image (listof (union string 'xml 'image))) @@ -1915,26 +1915,20 @@ the settings above should match r5rs (send interactions-text last-position)) (send interactions-text paste)))) - (let ([last-para (queue-callback/res (λ () (send interactions-text last-paragraph)))]) - (alt-return-in-interactions drs) - (wait-for-computation drs) - (let ([got - (fetch-output - drs - (queue-callback/res - (λ () - (send interactions-text paragraph-start-position (+ last-para 1)))) - (queue-callback/res - (λ () - (send interactions-text paragraph-end-position - (- (send interactions-text last-paragraph) 1)))))]) - (when (regexp-match re:out-of-sync got) - (error 'text-expression "got out of sync message")) - (unless (check-expectation repl-expected got) - (eprintf (make-err-msg repl-expected) - 'interactions - (language) - expression repl-expected got)))))) + (define last-para (queue-callback/res (λ () (send interactions-text last-paragraph)))) + (alt-return-in-interactions drs) + (wait-for-computation drs) + (define got + (fetch-output + drs + (queue-callback/res (λ () (send interactions-text paragraph-start-position (+ last-para 1)))) + (queue-callback/res (λ () + (send interactions-text paragraph-end-position + (- (send interactions-text last-paragraph) 1)))))) + (when (regexp-match re:out-of-sync got) + (error 'text-expression "got out of sync message")) + (unless (check-expectation repl-expected got) + (eprintf (make-err-msg repl-expected) 'interactions (language) expression repl-expected got)))) (define (test-undefined-var id #:icon+in? [icon+in? #f]) (test-expression diff --git a/drracket-test/tests/drracket/syncheck-test.rkt b/drracket-test/tests/drracket/syncheck-test.rkt index dca5af649..d2183e8dd 100644 --- a/drracket-test/tests/drracket/syncheck-test.rkt +++ b/drracket-test/tests/drracket/syncheck-test.rkt @@ -1770,29 +1770,28 @@ (copy-port in-port out-port))))) (fire-up-drracket-and-run-tests (λ () - (let ([drs (wait-for-drracket-frame)]) - ;(set-language-level! (list "Pretty Big")) - (begin - (set-language-level! (list "Pretty Big") #f) - (test:set-radio-box-item! "No debugging or profiling") - (let ([f (test:get-active-top-level-window)]) - (test:button-push "OK") - (wait-for-new-frame f))) - (do-execute drs) - (let* ([defs (queue-callback/res (λ () (send drs get-definitions-text)))] - [filename (make-temporary-file "syncheck-test~a" #f temp-dir)]) - (queue-callback/res (λ () (send defs save-file filename))) - (preferences:set 'framework:coloring-active #f) - (close-the-error-window-test drs) - (for-each (run-one-test temp-dir) tests) - (preferences:set 'framework:coloring-active #t) - (queue-callback/res - (λ () - (send defs save-file) ;; clear out autosave - (send defs set-filename #f))) - (delete-file filename) - - (printf "Ran ~a tests.\n" total-tests-run)))))) + (define drs (wait-for-drracket-frame)) + ;(set-language-level! (list "Pretty Big")) + (begin + (set-language-level! (list "Pretty Big") #f) + (test:set-radio-box-item! "No debugging or profiling") + (let ([f (test:get-active-top-level-window)]) + (test:button-push "OK") + (wait-for-new-frame f))) + (do-execute drs) + (define defs (queue-callback/res (λ () (send drs get-definitions-text)))) + (define filename (make-temporary-file "syncheck-test~a" #f temp-dir)) + (queue-callback/res (λ () (send defs save-file filename))) + (preferences:set 'framework:coloring-active #f) + (close-the-error-window-test drs) + (for-each (run-one-test temp-dir) tests) + (preferences:set 'framework:coloring-active #t) + (queue-callback/res (λ () + (send defs save-file) ;; clear out autosave + (send defs set-filename #f))) + (delete-file filename) + + (printf "Ran ~a tests.\n" total-tests-run)))) (λ () (delete-directory/files temp-dir)))) (define (close-the-error-window-test drs) @@ -1998,25 +1997,25 @@ (lexically-bound-variable lexically-bound))) (define (collapse-and-rename expected) - (let ([renamed - (map (lambda (ent) - (let* ([str (car ent)] - [id (cadr ent)] - [matches (assoc id remappings)]) - (if matches - (list str (cadr matches)) - ent))) - expected)]) - (let loop ([ids renamed]) - (cond - [(null? ids) null] - [(null? (cdr ids)) ids] - [else (let ([fst (car ids)] - [snd (cadr ids)]) - (if (eq? (cadr fst) (cadr snd)) - (loop (cons (list (string-append (car fst) (car snd)) (cadr fst)) - (cddr ids))) - (cons fst (loop (cdr ids)))))])))) + (define renamed + (map (lambda (ent) + (let* ([str (car ent)] + [id (cadr ent)] + [matches (assoc id remappings)]) + (if matches + (list str (cadr matches)) + ent))) + expected)) + (let loop ([ids renamed]) + (cond + [(null? ids) null] + [(null? (cdr ids)) ids] + [else + (let ([fst (car ids)] + [snd (cadr ids)]) + (if (eq? (cadr fst) (cadr snd)) + (loop (cons (list (string-append (car fst) (car snd)) (cadr fst)) (cddr ids))) + (cons fst (loop (cdr ids)))))]))) ;; compare-arrows : expression ;; (or/c #f (listof (cons (list number-or-proc number-or-proc) @@ -2049,23 +2048,23 @@ ;; binding-in-ht? : hash-table (list number number) (listof (list number number)) -> boolean (define (test-binding expected? ht) ;; dont-care (lambda (pr) - (let ([frm (car pr)] - [to (cdr pr)]) - (hash-ref - already-checked - frm - (lambda () - (hash-set! already-checked frm #t) - (define ht-ent (hash-ref ht frm 'nothing-there)) - (unless (equal? ht-ent to) - (eprintf (if expected? - "FAILED arrow test line ~a ~s from ~s\n expected ~s\n actual ~s\n" - "FAILED arrow test line ~a ~s from ~s\n actual ~s\n expected ~s\n") - line - test-exp - frm - ht-ent - to))))))) + (define frm (car pr)) + (define to (cdr pr)) + (hash-ref + already-checked + frm + (lambda () + (hash-set! already-checked frm #t) + (define ht-ent (hash-ref ht frm 'nothing-there)) + (unless (equal? ht-ent to) + (eprintf (if expected? + "FAILED arrow test line ~a ~s from ~s\n expected ~s\n actual ~s\n" + "FAILED arrow test line ~a ~s from ~s\n actual ~s\n expected ~s\n") + line + test-exp + frm + ht-ent + to)))))) (for-each (test-binding #t expected-ht) (hash-map actual-ht cons)) (for-each (test-binding #f actual-ht) (hash-map expected-ht cons)))) From 8465024cb589396a6f02e911aa5ee4f9b23e5b94 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:50 +0000 Subject: [PATCH 7/8] Fix 1 occurrence of `sort-with-keyed-comparator-to-sort-by-key` This `sort` expression can be replaced with a simpler, equivalent expression. --- drracket-test/tests/drracket/syncheck-test.rkt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drracket-test/tests/drracket/syncheck-test.rkt b/drracket-test/tests/drracket/syncheck-test.rkt index d2183e8dd..884a25a79 100644 --- a/drracket-test/tests/drracket/syncheck-test.rkt +++ b/drracket-test/tests/drracket/syncheck-test.rkt @@ -2040,8 +2040,7 @@ (define actual-ht (make-hash)) (for ([(k v) (in-hash raw-actual)]) (hash-set! actual-ht (cdr k) - (sort (map cdr (set->list v)) - (lambda (x y) (< (car x) (car y)))))) + (sort (map cdr (set->list v)) < #:key car))) (define expected-ht (make-hash)) (for ([binding (in-list expected)]) (hash-set! expected-ht (car binding) (cdr binding))) From 81e9852065b5cc4157783bdb9a9a3405c6940313 Mon Sep 17 00:00:00 2001 From: "resyntax-ci[bot]" <181813515+resyntax-ci[bot]@users.noreply.github.com> Date: Sun, 4 May 2025 00:11:50 +0000 Subject: [PATCH 8/8] Fix 1 occurrence of `if-then-true-else-false-to-condition` The condition of this `if` expression is already a boolean and can be used directly. --- drracket-test/tests/drracket/language-test.rkt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drracket-test/tests/drracket/language-test.rkt b/drracket-test/tests/drracket/language-test.rkt index f2cb113dc..4c2942a09 100644 --- a/drracket-test/tests/drracket/language-test.rkt +++ b/drracket-test/tests/drracket/language-test.rkt @@ -1686,7 +1686,7 @@ the settings above should match r5rs (when (and has-sharing? show-sharing) (fw:test:set-check-box! "Show sharing in values" - (if (eq? show-sharing 'on) #t #f))) + (eq? show-sharing 'on))) (fw:test:set-check-box! "Insert newlines in printed values" pretty?)