Merge pull request #1372 from rackerlabs/fix-wrong-ucvni

fix: add segmentation_id to ucvni create request

Author: haseebsyed12

python/understack-workflows/tests/test_oslo_event_neutron_network.py

@@ -51,6 +51,7 @@ def test_handle_network_create(network_create_event_data):
             "ucvni_group": {
                 "name": "FOO",
             },
+            "ucvni_id": 1862,
         },
     )
     assert result == 0
@@ -78,6 +79,7 @@ def test_handle_network_update(network_update_event_data):
             "ucvni_group": {
                 "name": "FOO",
             },
+            "ucvni_id": 1860,
         },
     )
     assert result == 0

python/understack-workflows/understack_workflows/oslo_event/neutron_network.py

@@ -21,6 +21,7 @@ class NetworkEvent:
     network_name: str
     tenant_id: UUID
     external: bool
+    provider_segmentation_id: int
 
     @classmethod
     def from_event_dict(cls, data: dict) -> Self:
@@ -31,6 +32,7 @@ def from_event_dict(cls, data: dict) -> Self:
             network["name"],
             UUID(network["project_id"]),
             bool(network["router:external"]),
+            int(network["provider:segmentation_id"]),
         )
 
 
@@ -66,13 +68,16 @@ def _create_nautobot_ucvni(
         ucvni_group_name = os.getenv("UCVNI_GROUP_NAME")
     if ucvni_group_name is None:
         raise RuntimeError("Please set environment variable UCVNI_GROUP_NAME")
+    if event.provider_segmentation_id is None:
+        raise RuntimeError("Network %s missing provider:segmentation_id", id)
 
     payload = {
         "id": id,
         "name": event.network_name,
         "status": {"name": "Active"},
         "tenant": str(event.tenant_id),
         "ucvni_group": {"name": ucvni_group_name},
+        "ucvni_id": event.provider_segmentation_id,
     }
     try:
         response = nautobot.plugins.undercloud_vni.ucvnis.create(payload)