Skip to content

Commit 974cbcd

Browse files
authored
Merge pull request #1056 from rackerlabs/fix-app-skip
fix(argocd): correct the git generator referencing the cluster
2 parents 8cb3182 + ce631fd commit 974cbcd

File tree

5 files changed

+10
-19
lines changed

5 files changed

+10
-19
lines changed

apps/appsets/appset-understack-global.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,8 @@ spec:
5353
repoURL: '{{ .values.deploy_url }}'
5454
revision: '{{ .values.deploy_ref }}'
5555
files:
56-
# due to https://github.com/argoproj/argo-cd/issues/22051
57-
# we need to do this workaround. this reads the apps.yaml
58-
# for per cluster
59-
- path: '{{ "{{.name}}" }}/apps.yaml'
56+
# this reads the overrides per cluster
57+
- path: '{{ .name }}/apps.yaml'
6058
selector:
6159
matchExpressions:
6260
# if you set skip to any value for the component in apps.yaml, this will disable it

apps/appsets/appset-understack-infra.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@ spec:
5454
repoURL: '{{ .values.deploy_url }}'
5555
revision: '{{ .values.deploy_ref }}'
5656
files:
57-
# due to https://github.com/argoproj/argo-cd/issues/22051
58-
# we need to do this workaround. this reads the apps.yaml
59-
# for per cluster
60-
- path: '{{ "{{.name}}" }}/apps.yaml'
57+
# this reads the overrides per cluster
58+
- path: '{{ .name }}/apps.yaml'
6159
selector:
6260
matchExpressions:
6361
# if you set skip to any value for the component in apps.yaml, this will disable it

apps/appsets/appset-understack-openstack.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,8 @@ spec:
5555
repoURL: '{{ .values.deploy_url }}'
5656
revision: '{{ .values.deploy_ref }}'
5757
files:
58-
# due to https://github.com/argoproj/argo-cd/issues/22051
59-
# we need to do this workaround
60-
- path: '{{ "{{.name}}" }}/apps.yaml'
58+
# this reads the overrides per cluster
59+
- path: '{{ .name }}/apps.yaml'
6160
selector:
6261
matchExpressions:
6362
# if you set skip to any value for the component in apps.yaml, this will disable it

apps/appsets/appset-understack-operators.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@ spec:
5454
repoURL: '{{ .values.deploy_url }}'
5555
revision: '{{ .values.deploy_ref }}'
5656
files:
57-
# due to https://github.com/argoproj/argo-cd/issues/22051
58-
# we need to do this workaround. this reads the apps.yaml
59-
# for per cluster
60-
- path: '{{ "{{.name}}" }}/apps.yaml'
57+
# this reads the overrides per cluster
58+
- path: '{{ .name }}/apps.yaml'
6159
selector:
6260
matchExpressions:
6361
# if you set skip to any value for the component in apps.yaml, this will disable it

apps/appsets/appset-understack-site.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,8 @@ spec:
5353
repoURL: '{{ .values.deploy_url }}'
5454
revision: '{{ .values.deploy_ref }}'
5555
files:
56-
# due to https://github.com/argoproj/argo-cd/issues/22051
57-
# we need to do this workaround. this reads the apps.yaml
58-
# for per cluster
59-
- path: '{{ "{{.name}}" }}/apps.yaml'
56+
# this reads the overrides per cluster
57+
- path: '{{ .name }}/apps.yaml'
6058
selector:
6159
matchExpressions:
6260
# if you set skip to any value for the component in apps.yaml, this will disable it

0 commit comments

Comments
 (0)