some improvements

Author: DanielePalaia

README.md

@@ -2,8 +2,17 @@
 
 This library is in early stages of development. It is meant to be used with RabbitMQ 4.0.
 
-## How to Run
+## How to Build the project and run the tests
+
+- Start a RabbitMQ 4.x broker
+- poetry build: build the source project
+- poetry install: resolves and install dependencies
+- poetry run pytest: run the tests
 
 ## Getting Started
 
+An example is provide in ./getting_started_main.py you can run it after starting a RabbitMQ 4.0 broker with:
+
+poetry run python ./examples/getting_started/main.py
+
 

examples/getting_started/main.py

@@ -48,7 +48,7 @@ def main() -> None:
     print("unbind")
     management.unbind(bind_name)
 
-    print("purging queue")
+    print("purging the queue")
     management.purge_queue(queue_name)
 
     print("delete queue")

rabbitmq_amqp_python_client/connection.py

@@ -28,12 +28,9 @@ def management(self) -> Management:
 
     # closes the connection to the AMQP 1.0 server.
     def close(self) -> None:
+        logger.debug("Closing connection")
         self._conn.close()
 
     def publisher(self, destination: str) -> Publisher:
         publisher = Publisher(self._conn, destination)
         return publisher
-
-    # TODO: returns the current status of the connection.
-    # def status(self) -> int:
-    #    pass

rabbitmq_amqp_python_client/entities.py

@@ -31,5 +31,4 @@ class QueueSpecification:
 class BindingSpecification:
     source_exchange: str
     destination_queue: str
-    # destination_exchange: str
     binding_key: str

rabbitmq_amqp_python_client/exceptions.py

@@ -3,6 +3,5 @@ class ValidationCodeException(Exception):
     def __init__(self, msg: str):
         self.msg = msg
 
-    # __str__ is to print() the value
     def __str__(self) -> str:
         return repr(self.msg)

rabbitmq_amqp_python_client/management.py

@@ -191,7 +191,6 @@ def _validate_reponse_code(
             "wrong response code received: " + str(response_code)
         )
 
-    # TODO
     def bind(self, bind_specification: BindingSpecification) -> str:
         logger.debug("Bind Operation called")
         body = {}
@@ -214,7 +213,6 @@ def bind(self, bind_specification: BindingSpecification) -> str:
         binding_path_with_queue = binding_path_with_exchange_queue(bind_specification)
         return binding_path_with_queue
 
-    # TODO
     def unbind(self, binding_exchange_queue_path: str) -> None:
         logger.debug("UnBind Operation called")
         self.request(
@@ -226,16 +224,10 @@ def unbind(self, binding_exchange_queue_path: str) -> None:
             ],
         )
 
-    # TODO
-    # def queue_info(self, queue_name:str):
-
-    # TODO
     def purge_queue(self, queue_name: str) -> None:
         logger.debug("purge_queue operation called")
         path = purge_queue_address(queue_name)
 
-        print("path: " + path)
-
         self.request(
             None,
             path,

rabbitmq_amqp_python_client/publisher.py

@@ -30,10 +30,11 @@ def publish(self, message: Message) -> None:
             self._sender.send(message)
 
     def close(self) -> None:
+        logger.debug("Closing Sender and Receiver")
         if self._sender is not None:
             self._sender.close()
-        # if self._receiver is not None:
-        #    self._receiver.close()
+        if self._receiver is not None:
+            self._receiver.close()
 
     def _create_sender(self, addr: str) -> BlockingSender:
         return self._conn.create_sender(addr, options=SenderOption(addr))

rabbitmq_amqp_python_client/qpid/proton/_message.py

@@ -556,6 +556,7 @@ def encode_delete(self) -> bytes:
                 continue
             else:
                 self._check(err)
+                # workaround because of: https://github.com/rabbitmq/rabbitmq-amqp-python-client/issues/1
                 if self.body is None:
                     data[0] = 0
                     data[1] = 83
@@ -580,6 +581,7 @@ def send(self, sender: "Sender", tag: Optional[str] = None) -> "Delivery":
         """
         dlv = sender.delivery(tag or sender.delivery_tag())
 
+        # workaround because of: https://github.com/rabbitmq/rabbitmq-amqp-python-client/issues/1
         if sender.target.address == "/management":
             encoded = self.encode_delete()
         else:
@@ -591,26 +593,6 @@ def send(self, sender: "Sender", tag: Optional[str] = None) -> "Delivery":
             dlv.settle()
         return dlv
 
-    def send_mngmnt(self, sender: "Sender", tag: Optional[str] = None) -> "Delivery":
-        """
-        Encodes and sends the message content using the specified sender,
-        and, if present, using the specified tag. Upon success, will
-        return the :class:`Delivery` object for the sent message.
-
-        :param sender: The sender to send the message
-        :param tag: The delivery tag for the sent message
-        :return: The delivery associated with the sent message
-        """
-        dlv = sender.delivery(tag or sender.delivery_tag())
-
-        encoded = self.encode_delete()
-
-        sender.stream(encoded)
-        sender.advance()
-        if sender.snd_settle_mode == Link.SND_SETTLED:
-            dlv.settle()
-        return dlv
-
     @overload
     def recv(self, link: "Sender") -> None: ...
 

tests/test_management.py

@@ -20,7 +20,6 @@ def test_declare_delete_exchange() -> None:
 
     assert exchange_info.name == exchange_name
 
-    # Still not working
     management.delete_exchange(exchange_name)
 
     connection.close()