Skip to content

Commit dcbffd8

Browse files
authored
Update matrix of options to support macos again. (#255)
The new versions of MacOS Runners are ARM based and the setup-python action doesn't support older python versions (before 3.11) on ARM. This PR updates the matrix to include both macos-latest (arm) and macos-13 (the last x86_64 version). It then use excludes to only run new python versions on ARM and older versions of x86. We miss out on coverage of someone compiling their own version of < 3.11 python on apple silicon, but I don't think that's too much of an issue. If we ever need to bump the minimum python version beyond 3.11 we can remove this. It also removes the parallelism limiters on the matrix computation (not sure why I added that, GitHub lets you have infinite parallel runners for now lol).
1 parent d3c288d commit dcbffd8

File tree

2 files changed

+26
-6
lines changed

2 files changed

+26
-6
lines changed

.github/workflows/end2endtest.yml

+13-3
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,20 @@ jobs:
1616
run:
1717
shell: bash
1818
strategy:
19-
max-parallel: 4
2019
matrix:
21-
os: [ubuntu-latest, windows-latest] # macos-latest, windows-latest]
22-
python-version: ["3.8", "3.9", "3.10", "3.11"]
20+
os: [ubuntu-latest, windows-latest, macos-latest, macos-13]
21+
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
22+
exclude:
23+
- os: macos-latest
24+
python-version: "3.8"
25+
- os: macos-latest
26+
python-version: "3.9"
27+
- os: macos-latest
28+
python-version: "3.10"
29+
- os: macos-13
30+
python-version: "3.11"
31+
- os: macos-13
32+
python-version: "3.12"
2333

2434
steps:
2535
- uses: actions/checkout@v2

.github/workflows/unittest.yml

+13-3
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,20 @@ jobs:
1616
run:
1717
shell: bash
1818
strategy:
19-
max-parallel: 12
2019
matrix:
21-
os: [ubuntu-latest, windows-latest] # macos-latest, windows-latest]
22-
python-version: ["3.8", "3.9", "3.10", "3.11"]
20+
os: [ubuntu-latest, windows-latest, macos-latest, macos-13]
21+
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
22+
exclude:
23+
- os: macos-latest
24+
python-version: "3.8"
25+
- os: macos-latest
26+
python-version: "3.9"
27+
- os: macos-latest
28+
python-version: "3.10"
29+
- os: macos-13
30+
python-version: "3.11"
31+
- os: macos-13
32+
python-version: "3.12"
2333

2434
steps:
2535
- uses: actions/checkout@v2

0 commit comments

Comments
 (0)