Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library(tidyverse) should treat tidyverse imports as Depends #2696

Open
MichaelChirico opened this issue Dec 6, 2024 · 1 comment
Open

Comments

@MichaelChirico
Copy link
Collaborator

Closely related to #2695, #2691.

After we solve #2695, we'll still get the same false positive as #2691 about mutate(), because {tidyverse} does not do package dependencies "correctly" -- it intentionally puts in Imports those packages which would elsewhere in the R ecosystem be in Depends, i.e. library(tidyverse) attaches its Imports (as opposed to just [possibly] loadNamespace() them):

tidyverse/tidyverse#40

I think {tidyverse} is basically alone in the R ecosystem in doing this, but is also extremely common in practice, so carving out some hand-curated code is IMO appropriate here.

@AshesITR
Copy link
Collaborator

AshesITR commented Dec 6, 2024

We maintain an internal fork of tidyverse as well, doing the same kind of abuse. It would be nice if the fix had a configuration setting for tidyverse-like packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants