You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After we solve #2695, we'll still get the same false positive as #2691 about mutate(), because {tidyverse} does not do package dependencies "correctly" -- it intentionally puts in Imports those packages which would elsewhere in the R ecosystem be in Depends, i.e. library(tidyverse)attaches its Imports (as opposed to just [possibly] loadNamespace() them):
I think {tidyverse} is basically alone in the R ecosystem in doing this, but is also extremely common in practice, so carving out some hand-curated code is IMO appropriate here.
The text was updated successfully, but these errors were encountered:
We maintain an internal fork of tidyverse as well, doing the same kind of abuse. It would be nice if the fix had a configuration setting for tidyverse-like packages.
Closely related to #2695, #2691.
After we solve #2695, we'll still get the same false positive as #2691 about
mutate()
, because {tidyverse} does not do package dependencies "correctly" -- it intentionally puts inImports
those packages which would elsewhere in the R ecosystem be inDepends
, i.e.library(tidyverse)
attaches itsImports
(as opposed to just [possibly]loadNamespace()
them):tidyverse/tidyverse#40
I think {tidyverse} is basically alone in the R ecosystem in doing this, but is also extremely common in practice, so carving out some hand-curated code is IMO appropriate here.
The text was updated successfully, but these errors were encountered: