-
-
Notifications
You must be signed in to change notification settings - Fork 430
libc::sendmmsg
is not available on old Android phones
#1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ugh, how old are these Android phones that you are targeting? If it's not too much complexity, we're happy to take a PR to enable support on older kernels. |
We support Android API 16, so the oldest phones are roughly 10 years old. I have created a PR for |
Fixed by #1504. |
I wonder whether the patch merged via #1504 is worth the trouble it is causing. In other words, I would like to discuss switching back to calling
//CC @link2xt, @flub and @dignifiedquire (since you have been active on chatmail/core#4007) |
Feel free to drop Android 4 support and bump API level to 21 (Android 5.0) if supporting it is too much trouble. This is what tokio did already and we already bump to API level 19 in deltachat/deltachat-android#3215 As for real use cases, Delta Chat has at least a few hundred Android 4 users according to Google Play statistics. |
This reverts commit e6f1844. e6f1844 called `sendmmsg` and `recvmmsg` through `libc::syscall` instead of `libc::sendmmsg` and `libc::recvmmsg`, thus preventing linking issues on old Android systems where `libc::sendmmsg` and `libc::recvmmsg` isn't available. In quinn-rs#1503 (comment) the decision was made to no longer support these old Android systems (API level 16). This commit reverts e6f1844. Given that `sendmmsg` support was previously dropped in ee08826, only the `recvmmsg` calls are reverted.
This reverts commit e6f1844. e6f1844 called `sendmmsg` and `recvmmsg` through `libc::syscall` instead of `libc::sendmmsg` and `libc::recvmmsg`, thus preventing linking issues on old Android systems where `libc::sendmmsg` and `libc::recvmmsg` isn't available. In quinn-rs#1503 (comment) the decision was made to no longer support these old Android systems (API level 16). This commit reverts e6f1844. Given that `sendmmsg` support was previously dropped in ee08826, only the `recvmmsg` calls are reverted.
This reverts commit e6f1844. e6f1844 called `sendmmsg` and `recvmmsg` through `libc::syscall` instead of `libc::sendmmsg` and `libc::recvmmsg`, thus preventing linking issues on old Android systems where `libc::sendmmsg` and `libc::recvmmsg` isn't available. In quinn-rs#1503 (comment) the decision was made to no longer support these old Android systems (API level 16). This commit reverts e6f1844. Given that `sendmmsg` support was previously dropped in ee08826, only the `recvmmsg` calls are reverted.
This reverts commit e6f1844. e6f1844 called `sendmmsg` and `recvmmsg` through `libc::syscall` instead of `libc::sendmmsg` and `libc::recvmmsg`, thus preventing linking issues on old Android systems where `libc::sendmmsg` and `libc::recvmmsg` isn't available. In quinn-rs#1503 (comment) the decision was made to no longer support these old Android systems (API level 16). This commit reverts e6f1844. Given that `sendmmsg` support was previously dropped in ee08826, only the `recvmmsg` calls are reverted.
This reverts commit e6f1844. e6f1844 called `sendmmsg` and `recvmmsg` through `libc::syscall` instead of `libc::sendmmsg` and `libc::recvmmsg`, thus preventing linking issues on old Android systems where `libc::sendmmsg` and `libc::recvmmsg` isn't available. In #1503 (comment) the decision was made to no longer support these old Android systems (API level 16). This commit reverts e6f1844. Given that `sendmmsg` support was previously dropped in ee08826, only the `recvmmsg` calls are reverted.
sendmmsg
was added in Linux 3.0 andrecvmmsg
was added in Linux 2.6.33 according to their man pages.It is used in
quinn/quinn-udp/src/unix.rs
Line 197 in 389d7ce
The text was updated successfully, but these errors were encountered: