io/fileview: use deleteLater() to delete file watchers

outfoxxed · outfoxxed · commit 0224fa942b93 · 2025-06-09T21:45:42.000-07:00
Fixes crashes when writing a file while watching it.
diff --git a/src/io/fileview.cpp b/src/io/fileview.cpp
@@ -490,7 +490,9 @@ void FileView::updatePath() {
 }
 
 void FileView::updateWatchedFiles() {
-	delete this->watcher;
+	// If inotify events are sent to the watcher after deletion and deleteLater
+	// isn't used, a use after free in the QML engine will occur.
+	if (this->watcher) this->watcher->deleteLater();
 
 	if (!this->targetPath.isEmpty() && this->bWatchChanges) {
 		qCDebug(logFileView) << "Creating watcher for" << this << "at" << this->targetPath;

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,9 @@ void FileView::updatePath() {`
`490`	`490`	`}`
`491`	`491`
`492`	`492`	`void FileView::updateWatchedFiles() {`
`493`		`- delete this->watcher;`
	`493`	`+ // If inotify events are sent to the watcher after deletion and deleteLater`
	`494`	`+ // isn't used, a use after free in the QML engine will occur.`
	`495`	`+ if (this->watcher) this->watcher->deleteLater();`
`494`	`496`
`495`	`497`	`if (!this->targetPath.isEmpty() && this->bWatchChanges) {`
`496`	`498`	`qCDebug(logFileView) << "Creating watcher for" << this << "at" << this->targetPath;`