Catch protocolVersion DeprecationWarnings

Author: kclowes

tests/core/version-module/test_version_module.py

@@ -53,4 +53,5 @@ async def test_async_blocking_version(async_w3, blocking_w3):
     assert async_w3.async_version.api == blocking_w3.api
 
     assert await async_w3.async_version.node == blocking_w3.clientVersion
-    assert await async_w3.async_version.ethereum == blocking_w3.eth.protocol_version
+    with pytest.warns(DeprecationWarning):
+        assert await async_w3.async_version.ethereum == blocking_w3.eth.protocol_version

web3/_utils/module_testing/eth_module.py

@@ -60,7 +60,9 @@
 
 class EthModuleTest:
     def test_eth_protocol_version(self, web3: "Web3") -> None:
-        protocol_version = web3.eth.protocol_version
+        with pytest.warns(DeprecationWarning,
+                          match="This method has been deprecated in some clients"):
+            protocol_version = web3.eth.protocol_version
 
         assert is_string(protocol_version)
         assert protocol_version.isdigit()
@@ -1558,7 +1560,9 @@ def test_eth_submit_hashrate(self, web3: "Web3") -> None:
     def test_eth_submitHashrate_deprecated(self, web3: "Web3") -> None:
         # node_id from EIP 1474: https://github.com/ethereum/EIPs/pull/1474/files
         node_id = HexStr('59daa26581d0acd1fce254fb7e85952f4c09d0915afd33d3886cd914bc7d283c')
-        result = web3.eth.submitHashrate(5000, node_id)
+        with pytest.warns(DeprecationWarning,
+                          match='submitHashrate is deprecated in favor of submit_hashrate'):
+            result = web3.eth.submitHashrate(5000, node_id)
         assert result is True
 
     def test_eth_submit_work(self, web3: "Web3") -> None:

web3/_utils/module_testing/version_module.py

@@ -13,7 +13,8 @@
 
 class VersionModuleTest:
     def test_eth_protocol_version(self, web3: "Web3") -> None:
-        protocol_version = web3.eth.protocol_version
+        with pytest.warns(DeprecationWarning):
+            protocol_version = web3.eth.protocol_version
 
         assert is_string(protocol_version)
         assert protocol_version.isdigit()