Skip to content

Commit bb5f0e8

Browse files
authored
Updates ddtrace dependency and switch to public tracing API (#2)
* Updates ddtrace dependency and switch to public tracing API Datadog bumped their major version in Spring 2022 and this gem was never updated to compensate. Pin to 1.X releases going forward and update the Datadog.tracer call to instead uses the proper public tracing API. * Creates release version for ddtrace update
1 parent e0510bc commit bb5f0e8

File tree

5 files changed

+16
-13
lines changed

5 files changed

+16
-13
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
## [Unreleased]
7+
## [1.0.0]
8+
- Updates ddtrace to the 1.X line and uses that version's `Datadog::Tracer` syntax
89

910
## [0.1.0]
1011

datadog-queue-bus.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ Gem::Specification.new do |spec|
3030
spec.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
3131
spec.require_paths = ['lib']
3232

33-
spec.add_dependency 'ddtrace', '~> 0.25'
33+
spec.add_dependency 'ddtrace', '~> 1.0'
3434
spec.add_dependency 'queue-bus', '~> 0.6'
3535

36-
spec.add_development_dependency 'bundler', '~> 1.17'
36+
spec.add_development_dependency 'bundler', '~> 2.4'
3737
spec.add_development_dependency 'rake', '~> 10.0'
3838
spec.add_development_dependency 'rspec', '~> 3.0'
3939
spec.add_development_dependency 'rubocop', '~> 0.72'

lib/datadog_queue_bus/middleware.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ def call(attrs)
1313
resource += " event=#{event_type}" if event_type
1414
resource += " sub=#{sub_key}" if sub_key
1515

16-
Datadog.tracer.trace('queue-bus.worker',
17-
service: DatadogQueueBus.service_name,
18-
resource: resource) do |span|
16+
# def trace(name, continue_from: nil, **span_options, &block)
17+
Datadog::Tracing.trace('queue-bus.worker',
18+
service: DatadogQueueBus.service_name,
19+
resource: resource) do |span|
1920
attrs.keys.grep(/^bus_/).each do |key|
2021
span.set_tag("queue-bus.#{key}", attrs[key])
2122
end

lib/datadog_queue_bus/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
module DatadogQueueBus
4-
VERSION = '0.1.0'
4+
VERSION = '1.0.0'
55
end

spec/datadog_queue_bus/middleware_spec.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
'bus_class_proxy' => 'QueueBus::Driver'
1212
}
1313
end
14+
let(:tracer) { Datadog::Tracing }
1415

1516
it 'uses the class_proxy_class as the resource name' do
16-
expect(Datadog.tracer)
17+
expect(tracer)
1718
.to receive(:trace)
1819
.with('queue-bus.worker', hash_including(resource: 'QueueBus::Driver'))
1920
subject.call(attrs)
@@ -27,7 +28,7 @@
2728
end
2829

2930
it 'sends the service name' do
30-
expect(Datadog.tracer)
31+
expect(tracer)
3132
.to receive(:trace)
3233
.with('queue-bus.worker', hash_including(service: name))
3334
subject.call(attrs)
@@ -40,7 +41,7 @@
4041
end
4142

4243
it 'includes the event in the resource' do
43-
expect(Datadog.tracer)
44+
expect(tracer)
4445
.to receive(:trace)
4546
.with('queue-bus.worker',
4647
hash_including(resource: a_string_matching(/event=my_event/)))
@@ -54,7 +55,7 @@
5455
end
5556

5657
it 'includes the sub key in the resource name' do
57-
expect(Datadog.tracer)
58+
expect(tracer)
5859
.to receive(:trace)
5960
.with('queue-bus.worker',
6061
hash_including(resource: a_string_matching(/sub=my_subscription/)))
@@ -69,7 +70,7 @@
6970

7071
it 'includes all attributes that start with bus_' do
7172
span = spy('span')
72-
expect(Datadog.tracer).to receive(:trace).and_yield(span)
73+
expect(tracer).to receive(:trace).and_yield(span)
7374
subject.call(attrs)
7475
expect(span).to have_received(:set_tag).with('queue-bus.bus_class_proxy', 'QueueBus::Driver')
7576
expect(span).to have_received(:set_tag).with('queue-bus.bus_field', 'my_field')
@@ -83,7 +84,7 @@
8384

8485
it 'includes all attributes that start with bus_' do
8586
span = spy('span')
86-
expect(Datadog.tracer).to receive(:trace).and_yield(span)
87+
expect(tracer).to receive(:trace).and_yield(span)
8788
subject.call(attrs)
8889
expect(span).to have_received(:set_tag).with('queue-bus.bus_class_proxy', 'QueueBus::Driver')
8990
expect(span).not_to have_received(:set_tag).with('queue-bus.user_id', 1234)

0 commit comments

Comments
 (0)