Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentProxy uses LC::Check::NoAction #63

Open
stdweird opened this issue Jun 5, 2016 · 3 comments
Open

ComponentProxy uses LC::Check::NoAction #63

stdweird opened this issue Jun 5, 2016 · 3 comments

Comments

@stdweird
Copy link
Member

stdweird commented Jun 5, 2016

Investigate if we should/can switch to CAF::Object::NoAction

@stdweird stdweird added this to the 16.8 milestone Jun 5, 2016
@stdweird stdweird modified the milestones: 16.10, 16.8 Aug 18, 2016
@stdweird
Copy link
Member Author

  • each component class sets CAF::Object::NoAction to the noaction from this_app
    • it is not reset on destroy or anything, a single load is enough
    • anything using CAF while running noaction in ncm-ncd uses NoAction
  • componentproxy sets LC::Check::NoAction (and sets it back afterwards)

propose to switch to a method to set and restore the Noaction on all possible related modules in ComponentProxy

@jrha jrha removed this from the 16.10 milestone Oct 19, 2016
@stdweird
Copy link
Member Author

also, every component has its own NoAction variable (and it's exported).
it is sometimes used by the components.

this variable is set first and then CAF::Object::NoAction gets the same value.

this is getting confusing very fast.

@stdweird stdweird added this to the 17.10 milestone Jun 14, 2017
@jrha
Copy link
Member

jrha commented Oct 25, 2017

Discussed at RAL workshop, concluded that this is not urgent, but if @stdweird feels like working on it... feel free.

ttyS4 pushed a commit to ttyS4/ncm-ncd that referenced this issue Dec 15, 2017
support for multiple profile failover urls
@jrha jrha removed this from the 18.3 milestone Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants