Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.12.62: allow to use rack fullname rather than name in machine template namespace #105

Closed
jouvin opened this issue Jul 7, 2018 · 4 comments
Closed

1.12.62: allow to use rack fullname rather than name in machine template namespace #105

jouvin opened this issue Jul 7, 2018 · 4 comments
Labels
wontfix

Comments

@jouvin
Copy link
Contributor

jouvin commented Jul 7, 2018 •
edited
Loading

The machine templates generated by the broker (machine directory in plenary templates) have a pan namespace reflecting the location hierarchy where the rack is designated by the rack name. But the rackname is a value generated by Aquilon, based on the room name, to ensure it is unique but as a consequence is not easily mapped to an actual rack (without using aq show rack), making difficult to navigate the machine templates.

As an option, it would be good to be able to use the rack fullname, that a site can use to reflect the actual rack name at the site (at LAL we use for the fullname the label which is written on the rack) instead of the rack (generated) name.

This issue is somewhat related to #104 machine/site proposed namespace fix but need to be controlled by a different option.
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
380bd0c 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
af8a432 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
795e272 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
1c96bf2 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
cd1ecac 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
5b99048 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 8, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
93035e1 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 9, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
c4cf4c1 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
@jouvin jouvin mentioned this issue Jul 9, 2018
Closed
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 13, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
f991825 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Jul 16, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
a04dc1d 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
@ned21
Copy link
Contributor

ned21 commented Jul 17, 2018

As an option, it would be good to be able to use the rack fullname

I think that's potentially risky as full names are not guaranteed to be valid pan, or perhaps even directories on the filesystem. Would it make sense to add an option to allow free-form rack codes that are not generated from the room name?

@jrha
Copy link
Member

jrha commented Jul 24, 2018

What is the use case for someone having to actually navigate the machine templates? I can't imagine why the average user should care what the directory structure is.

@jouvin
Copy link
Contributor Author

jouvin commented Aug 1, 2018

For the average user I don't know, for me when debugging things I can tell! Recently @urbonegi mentioned that there was internal discussions at MS about adding a new field that would be a rack label that could be defined by the site and would have to be a valid directory/pan namespace (we could even imagine to derive a default value from the full name). It would be perfectly ok for me.

jouvin added a commit to jouvin/aquilon that referenced this issue Aug 16, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
fcaea80 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Oct 22, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
4cbaf7f 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Nov 2, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
02b82a4 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc
jouvin added a commit to jouvin/aquilon that referenced this issue Nov 2, 2018
@jouvin
machine plenary templates: allow to use the rack fullname
c905336 
- If config option machine_ns_rack_fullname is true (default is false
to maintain backward compatibility, use the rack fullname instead of
the rack name to build the machine namespace in the plenary templates.
- When the option is true, also export the rack fullname instead of
the rack name in /hardware/rack/name.

Fixes quattor#105 (GitHub issue quattor#105)

Change-Id: I99dd2d0af0091dca588e576d45b18bd833100fbc

Conflicts:
	etc/aqd.conf.defaults
	lib/aquilon/worker/templates/base.py
	lib/aquilon/worker/templates/machine.py
@jrha
Copy link
Member

jrha commented Nov 2, 2018 •
edited
Loading

Discussed with @jouvin and @xaf after the workshop, this is not needed as the templates can be easily seen with aq cat --machine. If someone really wants to see the actual file lives, then the namespace is at the top of the aq cat output.

@jrha jrha closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ned21 @jrha @jouvin