Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode and brand yml #12159

Open
gordonwoodhull opened this issue Feb 26, 2025 · 1 comment
Open

dark mode and brand yml #12159

gordonwoodhull opened this issue Feb 26, 2025 · 1 comment
Assignees
Labels
brand `_brand.yml` enhancement New feature or request themes Related to HTML theming or any other style related issue (like highlight-style)
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

From posit-dev/brand-yml#68

@Aariq reports

I'm not sure if this belongs here or in the Quarto repo, but it appears like using theme: brand doesn't work for dark mode, only light mode. Perhaps this is just not implemented yet, but I was expecting something like this would work:

format:
  html:
    theme:
      light: brand
      dark:
        - brand
        - dark.scss

where dark.scss only overrides background and foreground colors. However, when I do this, I see that in dark mode the fonts and everything else changes. Even just using light: brand and dark: brand makes it clear that _brand.yml is only applied to light mode.

Tracking here for Quarto 1.7

@gordonwoodhull gordonwoodhull added this to the v1.7 milestone Feb 26, 2025
@gordonwoodhull gordonwoodhull self-assigned this Feb 26, 2025
@gordonwoodhull gordonwoodhull added the enhancement New feature or request label Feb 26, 2025
@mcanouil mcanouil added themes Related to HTML theming or any other style related issue (like highlight-style) brand `_brand.yml` labels Feb 26, 2025
@coatless
Copy link
Contributor

c.f. discussion: #11487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand `_brand.yml` enhancement New feature or request themes Related to HTML theming or any other style related issue (like highlight-style)
Projects
None yet
Development

No branches or pull requests

4 participants