Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarto listing filters return nothing when using any upper case characters #10720

Closed
e-kotov opened this issue Sep 4, 2024 · 3 comments · Fixed by #10725
Closed

quarto listing filters return nothing when using any upper case characters #10720

e-kotov opened this issue Sep 4, 2024 · 3 comments · Fixed by #10725
Assignees
Labels
bug Something isn't working listings regression Functionality that used to work but now is broken.
Milestone

Comments

@e-kotov
Copy link

e-kotov commented Sep 4, 2024

          I think this must be an issue introduced perhaps in a new release of Quarto? I don't see it in some older versions like:

https://web.archive.org/web/20230329074857/https://quarto.org/docs/extensions/

I think it is worth opening a new issue to track this.

Originally posted by @dragonstyle in #6755 (comment)

The issue

When using Quarto listings with filters, in some websites the filter returns no matches if the user inputs Any Upper Case Characters.

Where the problem exits

Where it does not exist and works as expected with Any case of Letters

Frankly, comparing the source and yaml headers of all these sites, I could not figure out what the reason for this behaviour is. Perhaps as suggested by @dragonstyle , this may be an issue that appears with certain versions of quarto.

@dragonstyle
Copy link
Collaborator

The problem exists in:
quarto-1.6.4
quarto-1.6.9
quarto-1.5.56

I think this is likely something new. Mine's tip a day was generated with quarto-1.0.37 fwiw.

Also visible on
https://quarto.org/docs/extensions/

@cderv cderv added listings bug Something isn't working regression Functionality that used to work but now is broken. labels Sep 5, 2024
@cderv
Copy link
Collaborator

cderv commented Sep 5, 2024

This comes from a patch in list.js that we imported in Quarto at a2e298e for 1.5.4. It solves #8435 but too strong because it will remove the toLowerCase()

We need to patch list.min.js differently so that #8435 is still solved, but it does not break the search.

@dragonstyle
Copy link
Collaborator

dragonstyle commented Sep 5, 2024

@cderv cderv self-assigned this Sep 5, 2024
@cderv cderv added this to the v1.6 milestone Sep 5, 2024
cderv added a commit that referenced this issue Sep 5, 2024
This is a follow up on a2e298e which patches list.min.js to fix #8435. The fix suggested in javve/list.js#699 only remove the regex handling. Our initial patch was also removing the lowercase processing which broke search.

This fixes #10720
@cderv cderv modified the milestones: v1.6, Hot-fix Sep 5, 2024
cderv added a commit that referenced this issue Sep 6, 2024
This is a follow up on a2e298e which patches list.min.js to fix #8435. The fix suggested in javve/list.js#699 only remove the regex handling. Our initial patch was also removing the lowercase processing which broke search.

This fixes #10720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working listings regression Functionality that used to work but now is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants