hibernate-orm-panache-kotlin-quickstart fails to build native after "Unconditionally enable complete reflection type changes in quarkus"

[rsvoboda]

Describe the bug

hibernate-orm-panache-kotlin-quickstart fails to build native after "Unconditionally enable complete reflection type changes in quarkus"

Failure of QS: #6588 (comment)

Build resources:
 - 11.80GB of memory (75.6% of 15.62GB system memory, determined at start)
 - 4 thread(s) (100.0% of 4 available processor(s), determined at start)
[2/8] Performing analysis...  []                                                                         (9.7s @ 0.38GB)
    3,318 reachable types   (57.0% of    5,821 total)
    2,715 reachable fields  (38.7% of    7,024 total)
    9,224 reachable methods (24.5% of   37,597 total)
    1,790 types,   788 fields, and 7,670 methods registered for reflection

Error: Class initialization of org.jboss.narayana.jta.jms.ConnectionManager failed. This error is reported at image build time because class org.jboss.narayana.jta.jms.ConnectionManager is registered for linking at image build time by command line and command line. Use the option 

    '--initialize-at-run-time=org.jboss.narayana.jta.jms.ConnectionManager'

 to explicitly request initialization of this class at run time.
Caused by: java.lang.NoClassDefFoundError: jakarta/jms/JMSException
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
	at org.graalvm.nativeimage.builder/

After reverting #51432 and #51473 I get native build working again, cc @jerboaa

Expected behavior

Native image build ends successfully.

Actual behavior

Native image build fails

How to Reproduce?

• git clone https://github.com/quarkusio/quarkus-quickstarts -b development
• sdk use java 23.1.9.r21-mandrel
• mvn clean package -DskipTests -f quarkus-quickstarts/hibernate-orm-panache-kotlin-quickstart -Dnative

Output of uname -a or ver

macOS

Output of java -version

Mandrel 23.1

Mandrel or GraalVM version (if different from Java)

Mandrel 23.1

Quarkus version or git rev

Quarkus main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @FroMage (panache), @Karm (native-image), @galderz (native-image), @geoand (kotlin), @gsmet (hibernate-orm), @loicmathieu (panache), @zakkak (native-image)

[jerboaa]

OK. That suggests this also fails with Mandrel 25 prior #51432 and with -Dquarkus.native.additional-build-args-append="--future-defaults=complete-reflection-types"? It would be good to confirm @rsvoboda

[rsvoboda]

mvn clean package -DskipTests -f hibernate-orm-panache-kotlin-quickstart -Dnative -Dquarkus.native.additional-build-args-append="--future-defaults=complete-reflection-types" gives

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project hibernate-orm-panache-kotlin-quickstart: Failed to build quarkus application: No enum constant io.quarkus.deployment.pkg.steps.NativeImageFutureDefault.COMPLETE_REFLECTION_TYPES -> [Help 1]

[rsvoboda]

sdk use java 25.0.1.r25-mandrel and mvn clean package -DskipTests -f hibernate-orm-panache-kotlin-quickstart -Dnative against main with reverted #51432 and #51473 works fine and the native binary gets produced

[jerboaa]

mvn clean package -DskipTests -f hibernate-orm-panache-kotlin-quickstart -Dnative -Dquarkus.native.additional-build-args-append="--future-defaults=complete-reflection-types" gives

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project hibernate-orm-panache-kotlin-quickstart: Failed to build quarkus application: No enum constant io.quarkus.deployment.pkg.steps.NativeImageFutureDefault.COMPLETE_REFLECTION_TYPES -> [Help 1]

Is this with #51432 and #51473 reverted?

[rsvoboda]

That was with main, there was no mention of reverted commits in the comment

Now some details for main with #51432 and #51473 reverted

25.0.1.r25-mandrel

FAIL - mvn clean package -DskipTests -f hibernate-orm-panache-kotlin-quickstart -Dnative -Dquarkus.native.additional-build-args-append="--future-defaults=complete-reflection-types"

PASS - mvn clean package -DskipTests -f hibernate-orm-panache-kotlin-quickstart -Dnative

[jerboaa]

OK. That makes more sense then.

[jerboaa]

So it's apparently this hunk from #51432 which broke this:

--- a/core/deployment/src/main/java/io/quarkus/deployment/steps/ReflectiveHierarchyStep.java
+++ b/core/deployment/src/main/java/io/quarkus/deployment/steps/ReflectiveHierarchyStep.java
@@ -38,7 +38,6 @@
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveHierarchyBuildItem;
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveHierarchyIgnoreWarningBuildItem;
 import io.quarkus.deployment.pkg.NativeConfig;
-import io.quarkus.deployment.pkg.steps.NativeImageFutureDefault;
 import io.quarkus.deployment.util.JandexUtil;
 
 public class ReflectiveHierarchyStep {
@@ -238,13 +237,11 @@ private void addClassTypeHierarchy(NativeConfig nativeConfig, CombinedIndexBuild
                 info.superName(), initialName,
                 processedReflectiveHierarchies,
                 unindexedClasses, reflectiveClass, visits));
-        if (NativeImageFutureDefault.COMPLETE_REFLECTION_TYPES.isEnabled(nativeConfig)) {
-            for (Type interfaceType : info.interfaceTypes()) {
-                visits.addLast(() -> addReflectiveHierarchy(nativeConfig, combinedIndexBuildItem, capabilities,
-                        reflectiveHierarchyBuildItem,
-                        source, interfaceType, processedReflectiveHierarchies, unindexedClasses,
-                        reflectiveClass, visits));
-            }
+        for (Type interfaceType : info.interfaceTypes()) {
+            visits.addLast(() -> addReflectiveHierarchy(nativeConfig, combinedIndexBuildItem, capabilities,
+                    reflectiveHierarchyBuildItem,
+                    source, interfaceType, processedReflectiveHierarchies, unindexedClasses,
+                    reflectiveClass, visits));
         }
         for (FieldInfo field : info.fields()) {
             if (reflectiveHierarchyBuildItem.getIgnoreFieldPredicate().test(field) ||

[jerboaa]

@galderz @zakkak Do you remember what led you to introduce this for the --future-defaults=complete-reflection-types case?

[jerboaa]

I'll also note that this particular quickstart produces the following warning of unindexed classes:

[INFO] --- quarkus:999-SNAPSHOT:build (default) @ hibernate-orm-panache-kotlin-quickstart ---
Warning:  [io.quarkus.arc.processor.BeanArchives] Failed to index org.apache.activemq.artemis.core.journal.Journal: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: PROD for hibernate-orm-panache-kotlin-quickstart-1.0.0-SNAPSHOT@50233166
Warning:  [io.quarkus.arc.processor.BeanArchives] Failed to index io.mashona.logwriting.ArrayStore: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: PROD for hibernate-orm-panache-kotlin-quickstart-1.0.0-SNAPSHOT@50233166
Warning:  [io.quarkus.arc.processor.BeanArchives] Failed to index org.apache.activemq.artemis.core.journal.RecordInfo: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: PROD for hibernate-orm-panache-kotlin-quickstart-1.0.0-SNAPSHOT@50233166
Warning:  [io.quarkus.deployment.steps.ReflectiveHierarchyStep] Unable to properly register the hierarchy of the following classes for reflection as they are not in the Jandex index:
	- io.mashona.logwriting.ArrayStore (source: ResteasyReactiveProcessor > org.acme.hibernate.orm.panache.FruitResource[jakarta.ws.rs.core.Response create(org.acme.hibernate.orm.panache.Fruit fruit)] > org.acme.hibernate.orm.panache.Fruit > org.acme.hibernate.orm.panache.Fruit > io.quarkus.hibernate.orm.panache.kotlin.PanacheCompanion > io.quarkus.hibernate.orm.panache.kotlin.PanacheCompanionBase > org.hibernate.Session > org.hibernate.SessionFactory > javax.naming.Referenceable > com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple > com.arjuna.ats.arjuna.AtomicAction > com.arjuna.ats.arjuna.objectstore.ParticipantStore > com.arjuna.ats.internal.arjuna.objectstore.slot.SlotStore > com.arjuna.ats.internal.arjuna.objectstore.slot.BackingSlots > io.mashona.logwriting.ArrayStore)
	- org.apache.activemq.artemis.core.journal.Journal (source: ResteasyReactiveProcessor > org.acme.hibernate.orm.panache.FruitResource[jakarta.ws.rs.core.Response create(org.acme.hibernate.orm.panache.Fruit fruit)] > org.acme.hibernate.orm.panache.Fruit > org.acme.hibernate.orm.panache.Fruit > io.quarkus.hibernate.orm.panache.kotlin.PanacheCompanion > io.quarkus.hibernate.orm.panache.kotlin.PanacheCompanionBase > org.hibernate.Session > org.hibernate.SessionFactory > javax.naming.Referenceable > com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple > com.arjuna.ats.arjuna.AtomicAction > com.arjuna.ats.arjuna.objectstore.ParticipantStore > com.arjuna.ats.internal.arjuna.objectstore.hornetq.HornetqJournalStore > org.apache.activemq.artemis.core.journal.Journal)
	- org.apache.activemq.artemis.core.journal.RecordInfo (source: ResteasyReactiveProcessor > org.acme.hibernate.orm.panache.FruitResource[jakarta.ws.rs.core.Response create(org.acme.hibernate.orm.panache.Fruit fruit)] > org.acme.hibernate.orm.panache.Fruit > org.acme.hibernate.orm.panache.Fruit > io.quarkus.hibernate.orm.panache.kotlin.PanacheCompanion > io.quarkus.hibernate.orm.panache.kotlin.PanacheCompanionBase > org.hibernate.Session > org.hibernate.SessionFactory > javax.naming.Referenceable > com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple > com.arjuna.ats.arjuna.AtomicAction > com.arjuna.ats.arjuna.objectstore.ParticipantStore > com.arjuna.ats.internal.arjuna.objectstore.hornetq.HornetqJournalStore > java.util.concurrent.ConcurrentMap > java.util.concurrent.ConcurrentMap > org.apache.activemq.artemis.core.journal.RecordInfo)
Consider adding them to the index either by creating a Jandex index for your dependency via the Maven plugin, an empty META-INF/beans.xml or quarkus.index-dependency properties.

See: https://github.com/quarkusio/quarkus-quickstarts/actions/runs/20085336089/job/57621398538#step:9:2665