Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find out if quil is going to provide binary wheels #6754

Closed
pavoljuhas opened this issue Oct 8, 2024 · 3 comments · Fixed by #6763
Closed

Find out if quil is going to provide binary wheels #6754

pavoljuhas opened this issue Oct 8, 2024 · 3 comments · Fixed by #6763
Assignees
@pavoljuhas
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

pip install cirq attempts to compile quil-0.13.0 source-only release,
which fails if host machine does not have rust installed, e.g.,
https://github.com/quantumlib/Cirq/actions/runs/11226159459/job/31206161707#step:7:1329
and the internal docs-from-notebooks building tool.

Related: rigetti/quil-rs#291

Cirq version

1.5.0.dev at 769ad50
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Oct 8, 2024
@pavoljuhas pavoljuhas self-assigned this Oct 8, 2024
@pavoljuhas
Copy link
Collaborator Author

cc @mhucka

pavoljuhas added a commit that referenced this issue Oct 8, 2024
@pavoljuhas
coverage - exclude code guarded by if TYPE_CHECKING (#6753)
9520466 
Such code is only used for mypy type-checking session.

Also add a temporary pin on quil to avoid source only 0.13.0,
which does not install without rust toolchain.

Related to #6754
@tubadzin tubadzin mentioned this issue Oct 9, 2024
Merged
@mayankmalik-colab mayankmalik-colab mentioned this issue Oct 10, 2024
Closed
@pavoljuhas
Copy link
Collaborator Author

As a temporary workaround, the development release of cirq has a pin to the previous version of quil and can be installed using

pip install cirq~=1.0.dev

pavoljuhas added a commit to pavoljuhas/Cirq that referenced this issue Oct 11, 2024
@pavoljuhas
Unpin the quil package
ecd2545 
The latest release quil-0.13.1 includes binary wheels.
Wheels were omitted unintentionally before due to a CI error.

Fixes: quantumlib#6754
@pavoljuhas pavoljuhas mentioned this issue Oct 11, 2024
Merged
@pavoljuhas
Copy link
Collaborator Author

Find out if quil is going to provide binary wheels

Yes, the updated release quil-0.13.1 has them - https://pypi.org/project/quil/0.13.1/#files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavoljuhas pavoljuhas

Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pyquil dependency and remove workaround pinning of quil pavoljuhas/Cirq
1 participant
@pavoljuhas