refactor: change --use-query-safe-response to accept boolean value

- Removed --no-use-query-safe-response flag
- Changed --use-query-safe-response to accept true/false value
- Default is now false (SafeResponse not exported by default)
- Only export SafeResponse for GET operations when flag is true
- Updated help text with clearer examples
- Updated test fixtures to default behavior (SafeResponse not exported)

Author: zedrdave

src/cli.ts

@@ -1502,18 +1502,16 @@ Options:
   --exclude-prefix PREFIX        Exclude operations with operationId starting with PREFIX
                                  (default: '_deprecated')
   --no-exclude                   Disable operation exclusion (include all operations)
-  --use-query-safe-response      Use ApiResponseSafe for GET operations by default
-                                 (default: true; query responses have only readonly fields required)
-  --no-use-query-safe-response   Disable safe response typing for GET operations
-                                 (all fields required, matching ApiResponse behavior)
+  --use-query-safe-response      Export SafeResponse type for GET operations
+                                 (default: false; use true to enable)
   --help, -h                     Show this help message
 
 Examples:
   npx @qualisero/openapi-endpoint ./api/openapi.json ./src/generated
   npx @qualisero/openapi-endpoint https://api.example.com/openapi.json ./src/api
   npx @qualisero/openapi-endpoint ./api.json ./src/gen --exclude-prefix _internal
   npx @qualisero/openapi-endpoint ./api.json ./src/gen --no-exclude
-  npx @qualisero/openapi-endpoint ./api.json ./src/gen --no-use-query-safe-response
+  npx @qualisero/openapi-endpoint ./api.json ./src/gen --use-query-safe-response true
 
 This command will generate:
   - openapi-types.ts   (TypeScript types from OpenAPI spec)
@@ -1524,13 +1522,17 @@ This command will generate:
   - api-schemas.ts     (Type aliases for schema objects from OpenAPI spec)
 
 Query Response Typing (--use-query-safe-response):
-  GET responses with this flag enabled use ApiResponseSafe, which requires only readonly
+  When enabled (true), GET operations export a SafeResponse type that requires only readonly
   fields (typically those provided by the server). This matches the semantic distinction:
   - POST/PATCH request bodies: optional fields (you don't have to provide everything)
   - GET response bodies: readonly fields are always present (server always returns them)
 
-  Disable this flag to require all fields (ApiResponse) if your API schema doesn't
-  properly distinguish readonly fields.
+  Example:
+    import { api } from './api-client'
+    const { data } = api.listPets.useQuery()
+    // data has type SafeResponse when --use-query-safe-response true
+
+  When disabled (default), only the Response type is exported.
 `)
 }
 
@@ -1843,7 +1845,7 @@ async function generateApiOperationsFile(
 function generateApiTypesContent(
   operationMap: Record<string, OperationInfo>,
   opEnums: Record<string, Record<string, Record<string, string>>>,
-  useQuerySafeResponse = true,
+  useQuerySafeResponse = false,
 ): string {
   const ids = Object.keys(operationMap).sort()
   const isQuery = (id: string) => ['GET', 'HEAD', 'OPTIONS'].includes(operationMap[id].method)
@@ -1933,7 +1935,7 @@ async function generateApiTypesFile(
   openApiSpec: OpenAPISpec,
   outputDir: string,
   excludePrefix: string | null,
-  useQuerySafeResponse = true,
+  useQuerySafeResponse = false,
 ): Promise<void> {
   console.log('🔨 Generating api-types.ts...')
   const operationMap = buildOperationMap(openApiSpec, excludePrefix)
@@ -1961,7 +1963,7 @@ async function main(): Promise<void> {
 
   // Parse options
   let excludePrefix: string | null = '_deprecated' // default
-  let useQuerySafeResponse = true // default to true
+  let useQuerySafeResponse = false // default to false
 
   for (let i = 0; i < optionArgs.length; i++) {
     if (optionArgs[i] === '--no-exclude') {
@@ -1976,9 +1978,21 @@ async function main(): Promise<void> {
         process.exit(1)
       }
     } else if (optionArgs[i] === '--use-query-safe-response') {
-      useQuerySafeResponse = true
-    } else if (optionArgs[i] === '--no-use-query-safe-response') {
-      useQuerySafeResponse = false
+      if (i + 1 < optionArgs.length && ['true', 'false'].includes(optionArgs[i + 1])) {
+        useQuerySafeResponse = optionArgs[i + 1] === 'true'
+        i++ // Skip next arg since we consumed it
+      } else {
+        console.error('❌ Error: --use-query-safe-response requires a value (true or false)')
+        printUsage()
+        process.exit(1)
+      }
+    } else if (optionArgs[i] === '--help' || optionArgs[i] === '-h') {
+      printUsage()
+      process.exit(0)
+    } else {
+      console.error(`❌ Error: Unknown option '${optionArgs[i]}'`)
+      printUsage()
+      process.exit(1)
     }
   }
 
@@ -1998,9 +2012,9 @@ async function main(): Promise<void> {
 
     // Log query safe response setting
     if (useQuerySafeResponse) {
-      console.log(`✅ Using ApiResponseSafe for GET operations (readonly fields only required)`)
+      console.log(`✅ SafeResponse enabled for GET operations`)
     } else {
-      console.log(`⚠️  Using ApiResponse for all operations (all fields required)`)
+      console.log(`ℹ️  SafeResponse not enabled`)
     }
 
     // Fetch and parse OpenAPI spec once

tests/fixtures/api-types.ts

@@ -51,8 +51,6 @@ export namespace Types {
   export namespace getConfigJson {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'getConfigJson'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'getConfigJson'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'getConfigJson'>
     /** Query parameters. */
@@ -63,8 +61,6 @@ export namespace Types {
   export namespace getDataV1Json {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'getDataV1Json'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'getDataV1Json'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'getDataV1Json'>
     /** Query parameters. */
@@ -75,8 +71,6 @@ export namespace Types {
   export namespace getOwners {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'getOwners'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'getOwners'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'getOwners'>
     /** Query parameters. */
@@ -87,8 +81,6 @@ export namespace Types {
   export namespace getPet {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'getPet'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'getPet'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'getPet'>
     /** Query parameters. */
@@ -99,8 +91,6 @@ export namespace Types {
   export namespace getPetPetId {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'getPetPetId'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'getPetPetId'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'getPetPetId'>
     /** Query parameters. */
@@ -111,8 +101,6 @@ export namespace Types {
   export namespace listPets {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'listPets'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'listPets'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'listPets'>
     /** Query parameters. */
@@ -126,8 +114,6 @@ export namespace Types {
   export namespace listUserPets {
     /** Full response type - all fields required. */
     export type Response = _ApiResponse<OpenApiOperations, 'listUserPets'>
-    /** Response type - only `readonly` fields required. Recommended for GET operations. */
-    export type SafeResponse = _ApiResponseSafe<OpenApiOperations, 'listUserPets'>
     /** Path parameters. */
     export type PathParams = _ApiPathParams<OpenApiOperations, 'listUserPets'>
     /** Query parameters. */