Skip to content

hard coded emails should be part of the configuration #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjanssen2 opened this issue Feb 25, 2024 · 2 comments · Fixed by #3384
Closed

hard coded emails should be part of the configuration #3375

sjanssen2 opened this issue Feb 25, 2024 · 2 comments · Fixed by #3384

Comments

@sjanssen2
Copy link
Contributor

if self.user.level in {'admin', 'wet-lab admin'}:
if value == 'error':
qdb.util.send_email(
'jdereus@health.ucsd.edu', msg['subject'],
msg['message'])

@antgonza
Copy link
Member

There at least a couple of scenarios where we send emails to alert people (based on previous discussions and request) but I agree that they might be better in a configuration file. I'll change the title of this issue.

@antgonza antgonza changed the title better not hard code Jeff's email address here hard coded emails should be part of the configuration Feb 25, 2024
@antgonza antgonza linked a pull request Mar 21, 2024 that will close this issue
@antgonza
Copy link
Member

Fixed here: #3384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants