Skip to content

Commit d0647cc

Browse files
authored
fix #3451 (#3452)
* fix #3451 * fix test_base_handlers.py * fix test_generate_analysis_list
1 parent 34d7d9a commit d0647cc

File tree

6 files changed

+292
-153
lines changed

6 files changed

+292
-153
lines changed

qiita_db/test/test_util.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,9 +790,11 @@ def test_generate_analysis_list(self):
790790
exp = [{'mapping_files': [
791791
(16, qdb.util.get_filepath_information(16)['fullpath'])],
792792
'description': 'A test analysis', 'artifacts': [8, 9], 'name':
793-
'SomeAnalysis', 'analysis_id': 1, 'visibility': 'private'},
793+
'SomeAnalysis', 'owner': '[email protected]', 'analysis_id': 1,
794+
'visibility': 'private'},
794795
{'mapping_files': [], 'description': 'Another test analysis',
795796
'artifacts': [], 'name': 'SomeSecondAnalysis',
797+
'owner': '[email protected]',
796798
'analysis_id': 2, 'visibility': 'private'}]
797799
# removing timestamp for testing
798800
for i in range(len(obs)):

qiita_db/util.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2114,7 +2114,7 @@ def generate_analysis_list(analysis_ids, public_only=False):
21142114
return []
21152115

21162116
sql = """
2117-
SELECT analysis_id, a.name, a.description, a.timestamp,
2117+
SELECT analysis_id, a.name, a.description, a.timestamp, a.email,
21182118
array_agg(DISTINCT artifact_id),
21192119
array_agg(DISTINCT visibility),
21202120
array_agg(DISTINCT CASE WHEN filepath_type = 'plain_text'
@@ -2135,7 +2135,8 @@ def generate_analysis_list(analysis_ids, public_only=False):
21352135

21362136
qdb.sql_connection.TRN.add(sql, [tuple(analysis_ids)])
21372137
for row in qdb.sql_connection.TRN.execute_fetchindex():
2138-
aid, name, description, ts, artifacts, av, mapping_files = row
2138+
aid, name, description, ts, owner, artifacts, \
2139+
av, mapping_files = row
21392140

21402141
av = 'public' if set(av) == {'public'} else 'private'
21412142
if av != 'public' and public_only:
@@ -2156,7 +2157,7 @@ def generate_analysis_list(analysis_ids, public_only=False):
21562157
results.append({
21572158
'analysis_id': aid, 'name': name, 'description': description,
21582159
'timestamp': ts.strftime("%m/%d/%y %H:%M:%S"),
2159-
'visibility': av, 'artifacts': artifacts,
2160+
'visibility': av, 'artifacts': artifacts, 'owner': owner,
21602161
'mapping_files': mapping_files})
21612162

21622163
return results

qiita_pet/handlers/analysis_handlers/base_handlers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ def analysis_description_handler_get_request(analysis_id, user):
8585
'analysis_is_public': analysis.is_public,
8686
'analysis_description': analysis.description,
8787
'analysis_mapping_id': analysis.mapping_file,
88+
'analysis_owner': analysis.owner.email,
8889
'alert_type': alert_type,
8990
'artifacts': artifacts,
9091
'analysis_reservation': analysis._slurm_reservation()[0],

qiita_pet/handlers/analysis_handlers/tests/test_base_handlers.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ def test_analysis_description_handler_get_request(self):
3838
'analysis_id': 1,
3939
'analysis_description': 'A test analysis',
4040
'analysis_mapping_id': 16,
41+
'analysis_owner': '[email protected]',
4142
'analysis_is_public': False,
4243
'alert_type': 'info',
4344
'artifacts': {
@@ -67,6 +68,7 @@ def test_analysis_description_handler_get_request(self):
6768
'analysis_id': 1,
6869
'analysis_description': 'A test analysis',
6970
'analysis_mapping_id': 16,
71+
'analysis_owner': '[email protected]',
7072
'analysis_is_public': False,
7173
'alert_type': 'info',
7274
'artifacts': {
@@ -98,6 +100,7 @@ def test_analysis_description_handler_get_request(self):
98100
'analysis_id': 1,
99101
'analysis_description': 'A test analysis',
100102
'analysis_mapping_id': 16,
103+
'analysis_owner': '[email protected]',
101104
'analysis_is_public': False,
102105
'alert_type': 'danger',
103106
'artifacts': {

0 commit comments

Comments
 (0)