Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add py-args and -- as command line parameters #9556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add py-args and -- as command line parameters #9556

wants to merge 2 commits into from

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Jan 14, 2025

Fixes #9544

@domi4484 @agiudiceandrea may I request feedback? Thanks

Goal:

Ticket(s): #

  • Backport to LTR documentation is requested

@DelazJ DelazJ added Project/Configuration project properties, global options and settings backport release_3.40 On merge create a backported pull request to 3.40 labels Jan 14, 2025
@agiudiceandrea
Copy link
Contributor

I found that the description of such parameters is missing in the documentation while fixing qgis/QGIS#60121 a bug qgis/QGIS#60120 about the --code parameter. Hope @domi4484 can provide a description of the parameters.

domi4484
domi4484 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@domi4484 domi4484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DelazJ looks good to me.

@agiudiceandrea thanks for pointing that out. They where documented only in the command line help.
Do you think there is something unclear or missing in the parameter descriptions?

@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Jan 15, 2025 •
edited
Loading

@domi4484, in your PR's description qgis/QGIS#50092 you mention a --code-args parameter. Is it an oversight? The code allows to use the --py-args parameter even without the --code parameter. Is it intended? Please have a look at qgis/QGIS#60134 in which such behaviour is considered unintended and removed.

@DelazJ
Copy link
Collaborator Author

DelazJ commented Jan 16, 2025

Yes, the code-args mention confuses me also at the start, reason why I requested more experienced eyes with the feature.

@domi4484
Copy link
Contributor

@agiudiceandrea @DelazJ ok I think I remember now :) Yes its a mistake in the comment. In the beginning I called it --code-args, but then renamed it to --py-args because its valid for each python execution inside QGIS and not only for the script passed with --code
I'll comment on qgis/QGIS#60134

@DelazJ @btzy
Typo fix
f688e5c 
Co-authored-by: Bernard Teo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btzy btzy btzy left review comments

@domi4484 domi4484 domi4484 approved these changes

Assignees
No one assigned
Labels
backport release_3.40 On merge create a backported pull request to 3.40 Project/Configuration project properties, global options and settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command line parameter --py-args (Request in QGIS)
4 participants
@DelazJ @agiudiceandrea @domi4484 @btzy