Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution_based_score_function failing when n=1 #873

Open
swatts-ci opened this issue Dec 31, 2024 · 1 comment
Open

distribution_based_score_function failing when n=1 #873

swatts-ci opened this issue Dec 31, 2024 · 1 comment

Comments

@swatts-ci
Copy link

Hey @joein - realised this fix wasn't sufficient.

When we get len(response) == 1:

  • We get a div by zero when calculating variance, as we are using Bessel's correction
  • Even without Bessel's correction, we'd get a div by zero later on when scaling the scores

We should instead not use the response when len(response) < 2

Originally posted by @swatts-ci in #815 (comment)

@jan-kubica
Copy link

@swatts-ci resolved by #872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants