Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Model Request]: Issue: DeprecationWarning for tar.extractall Filter Parameter in Python 3.14 and Inconsistent Behavior Across Platforms #327

Open
I8dNLo opened this issue Aug 15, 2024 · 0 comments

Comments

@I8dNLo
Copy link
Contributor

I8dNLo commented Aug 15, 2024

What happened?

The official Python 3.12 documentation suggests setting the filter to 'fully_trusted' and set automatic DeprecationWarning. However, this does not work correctly on at least Python 3.9 (in a CI macOS container) and Python 3.10. I suspect that the tarfile module relies on the built-in tar utility, which may exhibit platform-dependent behavior for the 'fully_trusted' flag.

This issue reproduces on macOS and possibly on Windows (Python 3.10 container), but only for models we download from our Google Drive, not from Hugging Face (HF). This leads me to believe that either the models from HF are fully trusted by default, or they are not unpacked using the tar utility.

Possible things to change:

  1. Add HF links for models where we haven't done so yet.
  2. Rename target files on our Google Drive from something like model_optimized.onnx to onnx/model.onnx, etc.
  3. Investigate the correct filter setting we should use.

What Python version are you on? e.g. python --version

Python 3.12

Version

0.2.7 (Latest)

What os are you seeing the problem on?

macos + python 3.9, macos + python 3.10, windows + python 3.10

Relevant stack traces and/or logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant