Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs are not closed if the browser navigation is used #895

Closed
1 of 6 tasks
Steffengreiner opened this issue Nov 13, 2024 · 1 comment · Fixed by #859
Closed
1 of 6 tasks

Dialogs are not closed if the browser navigation is used #895

Steffengreiner opened this issue Nov 13, 2024 · 1 comment · Fixed by #859
Labels
bug Something isn't working high prio tasks that require urgent attention simple Implementation effort

Comments

@Steffengreiner
Copy link
Contributor

Steffengreiner commented Nov 13, 2024 •
edited by sven1103
Loading

What happened?

While navigating between pages with the browser "one page back" and "one page forward" buttons, the currently opened dialog is not closed and i'm still able to update the information within the dialog.

Screen.Recording.2024-11-13.at.10.47.12.mov

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Affected Views:
@Steffengreiner Steffengreiner added bug Something isn't working triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Nov 13, 2024
@Steffengreiner Steffengreiner mentioned this issue Nov 13, 2024
Merged
@Steffengreiner Steffengreiner linked a pull request Nov 14, 2024 that will close this issue
Overhaul project summary page #859
Merged
@Steffengreiner Steffengreiner added simple Implementation effort high prio tasks that require urgent attention labels Jan 16, 2025
@Steffengreiner
Copy link
Contributor Author

Look into the afterleave hook during the vaadin navigation cycle to ensure the dialogs are closed properly

@Steffengreiner Steffengreiner moved this to Approve in Issue triage Jan 16, 2025
@sven1103 sven1103 moved this from Todo to In Progress in Sprint Planning Jan 17, 2025
@sven1103 sven1103 removed the triage An issue that is in discussion to be either scheduled for implepmentation or denied label Jan 17, 2025
@KochTobi KochTobi mentioned this issue Jan 23, 2025
Open
@sven1103 sven1103 moved this from In Progress to Done in Sprint Planning Jan 27, 2025
@sven1103 sven1103 closed this as completed by moving to Done in Sprint Planning Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high prio tasks that require urgent attention simple Implementation effort
Projects
Issue triage
Status: Approve
Sprint Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul project summary page qbicsoftware/data-manager-app
3 participants
@sven1103 @Steffengreiner @Shraddha0903