Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoporeParser should throw the custom DataParserExceptions and DataValidationExceptions #70

Open
Steffengreiner opened this issue Jul 20, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Steffengreiner
Copy link
Contributor

Steffengreiner commented Jul 20, 2021

Is your feature request related to a problem? Please describe.
Currently the NanoporeParser returns the everit ValidationException if the provided filetree doesn't follow the predefined schema.
This leads to the Issue that the applications using the NanoporeParser have to include the everit package as a dependency to interpret the exception.
Additionally, it returns different uncatched exceptions(IOException/ParserException/FileNotFoundException) dependent on why the parsing fails.

Describe the solution you'd like
Replace the ValidationException with the custom DatasetValidationException akin to the BioionformaticAnalysisParser and the MaxQuantParser.
The different Exceptions which could be generated during the parsing of a filetree, should be catched akin to the BioionformaticAnalysisParser and the MaxQuantParser and a custom DataParserException should be thrown for easier debugging.

@Steffengreiner Steffengreiner added the enhancement New feature or request label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant