Skip to content

Commit 0312e1d

Browse files
kiukchungfacebook-github-bot
authored andcommitted
Drop python-3.8 unittest in favor of adding 3.12. Update to python-3.10 for other workflows (#1020)
Summary: Pull Request resolved: #1020 PyTorch dropped support for python-3.8 a while ago. This change makes TorchX consistent with PyTorch. This should also fix gh workflow breakages in https://hud.pytorch.org/hud/pytorch/torchx/main Changes: 1. Drops python-3.8 in unittest matrix 2. Adds python-3.12 to unittest matrix 3. Upgrades a few libraries (torch, torchvision, etc) in dev-requirements.txt 4. Upgrades to python-3.10 in non-unittest workflows Reviewed By: manav-a Differential Revision: D71475986
1 parent 64635a8 commit 0312e1d

8 files changed

+11
-11
lines changed

.github/workflows/aws-batch-integration-tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Setup Python
1717
uses: actions/setup-python@v2
1818
with:
19-
python-version: 3.9
19+
python-version: "3.10"
2020
architecture: x64
2121
- name: Checkout TorchX
2222
uses: actions/checkout@v2

.github/workflows/components-integration-tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Setup Python
3636
uses: actions/setup-python@v2
3737
with:
38-
python-version: 3.8
38+
python-version: "3.10"
3939
architecture: x64
4040
- name: Checkout TorchX
4141
uses: actions/checkout@v2

.github/workflows/container.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Setup Python
1616
uses: actions/setup-python@v2
1717
with:
18-
python-version: 3.8
18+
python-version: "3.10"
1919
architecture: x64
2020
- name: Checkout TorchX
2121
uses: actions/checkout@v2

.github/workflows/gcp-batch-integration-tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Setup Python
1818
uses: actions/setup-python@v2
1919
with:
20-
python-version: 3.9
20+
python-version: "3.10"
2121
architecture: x64
2222
- name: Checkout TorchX
2323
uses: actions/checkout@v2

.github/workflows/kfp-integration-tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- name: Setup Python
1414
uses: actions/setup-python@v2
1515
with:
16-
python-version: 3.8
16+
python-version: "3.10"
1717
architecture: x64
1818
- name: Checkout TorchX
1919
uses: actions/checkout@v2

.github/workflows/python-unittests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
unittest:
1111
strategy:
1212
matrix:
13-
python-version: [3.8, 3.9, "3.10", 3.11]
13+
python-version: [3.9, "3.10", 3.11, 3.12]
1414
platform: ["linux.20_04.4x"]
1515
include:
1616
- python-version: 3.9

.github/workflows/slurm-local-integration-tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Python
2020
uses: actions/setup-python@v2
2121
with:
22-
python-version: 3.8
22+
python-version: "3.10"
2323
architecture: x64
2424
- name: Checkout TorchX
2525
uses: actions/checkout@v2

dev-requirements.txt

+4-4
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ pytorch-lightning==2.3.1
2424
tensorboard==2.14.0
2525
sagemaker==2.224.4
2626
torch-model-archiver>=0.4.2
27-
torch==2.2.1
28-
torchmetrics==0.10.3
27+
torch>=2.6.0
28+
torchmetrics==1.6.3
2929
torchserve>=0.10.0
30-
torchtext==0.17.1
31-
torchvision==0.17.1
30+
torchtext==0.18.0
31+
torchvision==0.21.0
3232
ts==0.5.1
3333
ray[default]
3434
wheel

0 commit comments

Comments
 (0)