Skip to content

Commit 8054bbb

Browse files
authored
ci: Give correct job names to binary builds (#6438)
Binary build workflows were getting named incorrectly so this should name them the things that they're actually doing. Example of what our old naming scheme looked like: ![Screenshot 2025-03-18 at 1 21 10 PM](https://github.com/user-attachments/assets/0147af71-23de-45fe-8a5e-b64cb33f3011) Signed-off-by: Eli Uriegas <[email protected]>
1 parent 79eb640 commit 8054bbb

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/workflows/_binary_upload.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
fail-fast: false
5050
matrix: ${{ fromJSON(inputs.build-matrix) }}
5151
timeout-minutes: 30
52-
name: ${{ matrix.build_name }}
52+
name: upload-${{ matrix.build_name }}
5353
env:
5454
DO_UPLOAD: ${{ contains(matrix.validation_runner, 'windows') || contains(matrix.validation_runner, 'macos') || contains(matrix.container_image, '2_28') || contains(matrix.container_image, 'manylinuxaarch64-builder:cuda') }}
5555
steps:

.github/workflows/build_wheels_linux.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124
UPLOAD_TO_BASE_BUCKET: ${{ matrix.upload_to_base_bucket }}
125125
ARCH: ${{ inputs.architecture }}
126126
IS_MANYLINUX2_28: ${{ contains(matrix.container_image, '2_28') || contains(matrix.container_image, 'manylinuxaarch64-builder:cuda') }}
127-
name: ${{ matrix.build_name }}
127+
name: build-${{ matrix.build_name }}
128128
runs-on: ${{ matrix.validation_runner }}
129129
environment: ${{(inputs.trigger-event == 'schedule' || (inputs.trigger-event == 'push' && (startsWith(github.event.ref, 'refs/heads/nightly') || startsWith(github.event.ref, 'refs/tags/v')))) && 'pytorchbot-env' || ''}}
130130
container:

.github/workflows/build_wheels_macos.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
REPOSITORY: ${{ inputs.repository }}
105105
REF: ${{ inputs.ref }}
106106
CU_VERSION: ${{ matrix.desired_cuda }}
107-
name: ${{ matrix.build_name }}
107+
name: build-${{ matrix.build_name }}
108108
runs-on: ${{ inputs.runner-type }}
109109
# If a build is taking longer than 60 minutes on these runners we need
110110
# to have a conversation

.github/workflows/build_wheels_windows.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
REF: ${{ inputs.ref }}
8686
CU_VERSION: ${{ matrix.desired_cuda }}
8787
UPLOAD_TO_BASE_BUCKET: ${{ matrix.upload_to_base_bucket }}
88-
name: ${{ matrix.build_name }}
88+
name: build-${{ matrix.build_name }}
8989
runs-on: ${{ matrix.validation_runner }}
9090
defaults:
9191
run:

0 commit comments

Comments
 (0)