Skip to content

Commit 1ab676a

Browse files
committed
fix build errors
1 parent 2804672 commit 1ab676a

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-up-chron.test.ts

+8-4
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ jest.mock('./gh-runners');
1414
jest.mock('./gh-issues');
1515
jest.mock('./utils');
1616
jest.mock('axios');
17-
17+
// @ts-ignore
1818
const responseString1 = '[{"runner_label":"test_runner_type1","org":"test_org1","repo":"test_repo1","num_queued_jobs":1,"min_queue_time_minutes":1,"max_queue_time_minutes":1},{"runner_label":"test_runner_type2","org":"test_org2","repo":"test_repo2","num_queued_jobs":2,"min_queue_time_minutes":2,"max_queue_time_minutes":2}]';
19+
// @ts-ignore
1920
const responseString2 = '[{"runner_label":"label1-nomatch","org":"test_org1","repo":"test_repo1","num_queued_jobs":1,"min_queue_time_minutes":1,"max_queue_time_minutes":1},{"runner_label":"test_runner_type2","org":"test_org2","repo":"test_repo2","num_queued_jobs":2,"min_queue_time_minutes":2,"max_queue_time_minutes":2}]';
21+
// @ts-ignore
2022
const responseString3 = '[{"runner_label":"label1","org":"test_org1-nomatch","repo":"test_repo1","num_queued_jobs":1,"min_queue_time_minutes":1,"max_queue_time_minutes":1},{"runner_label":"test_runner_type2","org":"test_org2","repo":"test_repo2","num_queued_jobs":2,"min_queue_time_minutes":2,"max_queue_time_minutes":2}]';
2123

2224
const baseCfg = {
@@ -94,17 +96,19 @@ describe('getQueuedJobs', () => {
9496

9597
it('get queue data from url request with invalid response', async () => {
9698
mocked(expBackOff).mockImplementation(
97-
() => {throw new Error('Throwing a fake error!')});
99+
() => {
100+
throw new Error('Throwing a fake error!');
101+
});
98102

99-
const runners = await getQueuedJobs(metrics, 'url');
103+
await getQueuedJobs(metrics, 'url');
100104
expect(await getQueuedJobs(metrics, 'url')).toEqual([]);
101105
});
102106

103107
it('get queue data from url request with empty response', async () => {
104108
const errorResponse = '';
105109
mocked(expBackOff).mockResolvedValue({ data: errorResponse });
106110

107-
const runners = await getQueuedJobs(metrics, 'url');
111+
await getQueuedJobs(metrics, 'url');
108112
expect(await getQueuedJobs(metrics, 'url')).toEqual([]);
109113
});
110114
});

terraform-aws-github-runner/modules/runners/lambdas/runners/src/scale-runners/scale-up-chron.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ export async function scaleUpChron(metrics: ScaleUpChronMetrics): Promise<void>
3333
}).filter((requested_runner) => {
3434
return Array.from(validRunnerTypes.keys()).some((available_runner_label) => {
3535
return available_runner_label === requested_runner.runner_label;
36-
})
37-
});;
36+
});
37+
});
3838

3939
if (queuedJobs.length === 0) {
4040
metrics.scaleUpInstanceNoOp();

0 commit comments

Comments
 (0)