Set test seed per-test#19744
Open
GregoryComer wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19744
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 140cbf3 with merge base 2b7a5a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
GregoryComer
added
release notes: none
metascroy
approved these changes
May 22, 2026
GregoryComer
force-pushed
the
test-seeding-round-2
branch
from
2c56155 to
140cbf3
Compare
meta-cla
Bot
added
the
CLA Signed
Member
Author
|
Note: the test_replace_conv1d_with_linear test seems to be slightly out of tolerance with this change. The failure is stable across retries, which implies that the seeding works. I've bumped the tolerance a tiny bit. It seems reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #19651, I added a global seed for pytest runs. This was intended to reduce random tolerance flakes, but didn't actually do so in practice. This is because the parallel test runners don't guarantee any ordering, so random state is unstable between runs.
I've updated it to set the seed per-test. This should hopefully make the random state invariant of test execution order.