Skip to content

Arm backend: Up tolerance when running on Aarch64#19110

Merged
Christoffer-JL merged 1 commit into
pytorch:mainfrom
Christoffer-JL:cjoh_review
May 11, 2026
Merged

Arm backend: Up tolerance when running on Aarch64#19110
Christoffer-JL merged 1 commit into
pytorch:mainfrom
Christoffer-JL:cjoh_review

Conversation

@Christoffer-JL
Copy link
Copy Markdown
Collaborator

@Christoffer-JL Christoffer-JL commented Apr 24, 2026

Increase the atol by 10% when running on Aarch64.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Increase the atol by 10% when running on Aarch64.

Signed-off-by: Christoffer J.L <[email protected]>
Change-Id: Idc3510eb1cbf83b090805645ee666ad1682186c6
@Christoffer-JL Christoffer-JL added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 24, 2026
@Christoffer-JL Christoffer-JL added the release notes: arm Changes to the ARM backend delegate label Apr 24, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19110

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Cancelled Job, 5 Unrelated Failures

As of commit d2e412f with merge base b6cec38 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label Apr 24, 2026
@mergennachin
Copy link
Copy Markdown
Contributor

Is there a tracking issue for this?

@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Apr 24, 2026

Is there a tracking issue for this?

There is a non public
MLETORCH-2048 but non in GitHub.

@Christoffer-JL
Copy link
Copy Markdown
Collaborator Author

Failing tests are unrelated

@zingo
Copy link
Copy Markdown
Collaborator

zingo commented Apr 27, 2026

@mergennachin

Is there a tracking issue for this?

Do you want a github ticket also? OK to merge/way forward to merge?

@Christoffer-JL
Copy link
Copy Markdown
Collaborator Author

bump

@Christoffer-JL
Copy link
Copy Markdown
Collaborator Author

I created an issue to track this: #19452
@mergennachin

Copy link
Copy Markdown
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge, issue created for future tracking so we don't forget to remove this in the future.

@Christoffer-JL Christoffer-JL merged commit fda2451 into pytorch:main May 11, 2026
437 of 450 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants