Extend CPPCHECK scope to aten kernels

Remove kernels/aten from the CPPCHECK exclude list after fixing its
only diagnostic.

The _empty_dim_order validation kept the fallback dim_order vector in
the outer function scope so that an ArrayRef could be assigned after
the optional branch. Move the shared validation into a local helper
and create the fallback vector only on the no-dim_order path, which
satisfies cppcheck without changing the validation behavior.

Signed-off-by: Per Held <per.held@arm.com>
Change-Id: Ic7f4d859d7d0aa531ebe51e3c5ea73f46bb28ef4

Author: perheld

.lintrunner.toml

@@ -193,7 +193,6 @@ exclude_patterns = [
     'extension/wasm/**',
 
     # Kernel areas to onboard separately.
-    'kernels/aten/**',
     'kernels/optimized/**',
     'kernels/portable/**',
     'kernels/prim_ops/**',

kernels/aten/cpu/op__empty_dim_order.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) Meta Platforms, Inc. and affiliates.
+ * Copyright 2026 Arm Limited and/or its affiliates.
  * All rights reserved.
  *
  * This source code is licensed under the BSD-style license found in the
@@ -26,23 +27,9 @@ const size_t kMaxNumOfDimensions = 16;
 
 namespace {
 
-inline bool _check__empty_out_dim_order(
-    OptionalIntArrayRef dim_order,
+inline bool check_empty_out_dim_order_ref(
+    executorch::aten::ArrayRef<int64_t> dim_order_ref,
     Tensor& out) {
-  executorch::aten::ArrayRef<int64_t> dim_order_ref;
-  std::vector<int64_t> dim_order_vec;
-
-  if (dim_order.has_value()) {
-    // out tensor's dim order shall equal to input dim order
-    dim_order_ref = executorch::aten::ArrayRef<int64_t>(
-        dim_order.value().data(), dim_order.value().size());
-  } else { // dim_order is not set, out tensor should be contiguous dim order
-    for (int i = 0; i < out.dim(); i++) {
-      dim_order_vec.push_back(i);
-    }
-    dim_order_ref = executorch::aten::ArrayRef<int64_t>(dim_order_vec);
-  }
-
   // dim order size shall equal to input dim
   ET_LOG_AND_RETURN_IF_FALSE(dim_order_ref.size() == out.dim());
 
@@ -65,6 +52,24 @@ inline bool _check__empty_out_dim_order(
   return true;
 }
 
+inline bool _check__empty_out_dim_order(
+    OptionalIntArrayRef dim_order,
+    Tensor& out) {
+  if (dim_order.has_value()) {
+    // out tensor's dim order shall equal to input dim order
+    return check_empty_out_dim_order_ref(executorch::aten::ArrayRef<int64_t>(
+        dim_order.value().data(), dim_order.value().size()));
+  } else { // dim_order is not set, out tensor should be contiguous dim order
+    std::vector<int64_t> dim_order_vec;
+    dim_order_vec.reserve(out.dim());
+    for (int i = 0; i < out.dim(); i++) {
+      dim_order_vec.push_back(i);
+    }
+    return check_empty_out_dim_order_ref(
+        executorch::aten::ArrayRef<int64_t>(dim_order_vec));
+  }
+}
+
 } // namespace
 
 /*