Skip to content

Commit b1385db

Browse files
authored
fix broken cuda tests (#19998)
Differential Revision: D107449731 Pull Request resolved: #19998
1 parent d76bbe3 commit b1385db

2 files changed

Lines changed: 24 additions & 13 deletions

File tree

extension/module/test/module_device_memory_test.cpp

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -146,17 +146,28 @@ TEST_F(ModuleDeviceMemoryTest, DeviceModelMethodMetaReportsCudaBuffer) {
146146
auto meta = module.method_meta("forward");
147147
ASSERT_TRUE(meta.ok());
148148

149-
// ModuleAddWithDevice has 1 planned buffer (48 bytes) on CUDA.
150-
ASSERT_EQ(meta->num_memory_planned_buffers(), 1);
149+
ASSERT_EQ(meta->num_memory_planned_buffers(), 2);
151150

152-
auto size = meta->memory_planned_buffer_size(0);
153-
ASSERT_TRUE(size.ok());
154-
EXPECT_EQ(size.get(), 48);
155-
156-
auto device = meta->memory_planned_buffer_device(0);
157-
ASSERT_TRUE(device.ok());
158-
EXPECT_EQ(device->type(), DeviceType::CUDA);
159-
EXPECT_EQ(device->index(), 0);
151+
{
152+
auto size = meta->memory_planned_buffer_size(0);
153+
ASSERT_TRUE(size.ok());
154+
EXPECT_EQ(size.get(), 48);
155+
156+
auto device = meta->memory_planned_buffer_device(0);
157+
ASSERT_TRUE(device.ok());
158+
EXPECT_EQ(device->type(), DeviceType::CPU);
159+
EXPECT_EQ(device->index(), 0);
160+
}
161+
{
162+
auto size = meta->memory_planned_buffer_size(1);
163+
ASSERT_TRUE(size.ok());
164+
EXPECT_EQ(size.get(), 48);
165+
166+
auto device = meta->memory_planned_buffer_device(1);
167+
ASSERT_TRUE(device.ok());
168+
EXPECT_EQ(device->type(), DeviceType::CUDA);
169+
EXPECT_EQ(device->index(), 0);
170+
}
160171
}
161172

162173
TEST_F(ModuleDeviceMemoryTest, DeviceModelWithSharedArenasReturnsNotSupported) {

runtime/executor/test/tensor_parser_device_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,8 @@ TEST_F(TensorParserDeviceTest, CUDADeviceParsedFromPteFile) {
198198

199199
EXPECT_EQ(cuda_tensor_count, 3)
200200
<< "Expected 3 CUDA tensors (2 delegate inputs + 1 delegate output)";
201-
EXPECT_EQ(cpu_tensor_count, 0)
202-
<< "Expected 0 CPU tensors (all annotated as CUDA)";
201+
EXPECT_EQ(cpu_tensor_count, 3)
202+
<< "Expected 3 CPU tensors (2 method inputs + 1 method output)";
203203
}
204204

205205
TEST_F(TensorParserDeviceTest, NonDelegatedTensorsDefaultToCPU) {
@@ -260,7 +260,7 @@ TEST_F(TensorParserDeviceTest, CudaTensorDataPtrPointsToDeviceMemory) {
260260
// non_const_buffer_sizes: [0, 48] (index 0 reserved, buffer 0 = 48 bytes)
261261
// non_const_buffer_device: [{buffer_idx=1, device_type=CUDA}]
262262
const size_t num_buffers = method_meta->num_memory_planned_buffers();
263-
ASSERT_EQ(num_buffers, 1);
263+
ASSERT_EQ(num_buffers, 2);
264264

265265
// Set up device-aware planned memory.
266266
std::vector<Span<uint8_t>> planned_spans;

0 commit comments

Comments
 (0)