Skip to content

Commit a23f524

Browse files
bigfootjonmeta-codesync[bot]
bigfootjon
authored and
meta-codesync[bot]
committed
promote TARGETS content into placeholder BUCK files (#20407)
Summary: Pull Request resolved: #20407 Chunk 4 of fbcode/executorch TARGETS->BUCK migration. 9 directories where TARGETS contained the real fbcode-side build rules and BUCK was a tiny placeholder (most were 4-8 lines like 'empty BUCK file to unblock landing'). Each TARGETS was scanned for fbcode-only constructs (`fbcode_macros`, `fbcode_target(`, `cpp_unittest(`, `cpp_library(`, `cpp_binary(`, `re_test_utils`, `keep_gpu_sections`, `buck_genrule`, `//tools/build/buck/`) and only those without any of those flags are migrated here. The TARGETS content is copied into BUCK (overwriting the placeholder) and the TARGETS file is deleted. fbcode now resolves these dirs via BUCK instead of TARGETS; the rules also become visible to xplat for the first time via dirsync. Directories migrated: - backends/apple/mps - backends/xnnpack/serialization - devtools/bundled_program - devtools/bundled_program/schema - devtools/etdump/fb - exir/emit - extension/pytree - extension/training - kernels/portable/test 8 PROMOTE candidates remain on TARGETS for follow-up: backends/cortex_m/test, examples/models/llama/fb, examples/qualcomm/oss_scripts/{llama,whisper}, exir/dialects/edge/test, exir/tests, kernels/fb/custom_ops, test/end2end. They have fbcode-only loads (`fbcode_macros`) or kwargs and need `is_fbcode()` gating. Reviewed By: mzlee Differential Revision: D109082058
1 parent ddc5e7d commit a23f524

16 files changed

Lines changed: 307 additions & 341 deletions

File tree

‎backends/apple/mps/BUCK‎

Lines changed: 93 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,102 @@
44
#
55

66
# Any targets that should be shared between fbcode and xplat must be defined in
7-
# targets.bzl. This file can contain xplat-only targets.
7+
# targets.bzl. This file can contain fbcode-only targets.
88

9-
load("@fbsource//tools/build_defs:default_platform_defs.bzl", "APPLE")
9+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target")
10+
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
1011
load(":targets.bzl", "define_common_targets")
1112

1213
oncall("executorch")
1314

14-
define_common_targets(
15-
is_xplat = True,
16-
platforms = [APPLE],
15+
define_common_targets()
16+
17+
fbcode_target(
18+
_kind = runtime.python_library,
19+
name = "backend",
20+
srcs = [
21+
"__init__.py",
22+
"mps_preprocess.py",
23+
],
24+
visibility = ["PUBLIC"],
25+
deps = [
26+
":operators",
27+
":serialization",
28+
":utils",
29+
"//caffe2:torch",
30+
"//executorch/exir/backend:backend_details",
31+
"//executorch/exir/backend:compile_spec_schema",
32+
],
33+
)
34+
35+
fbcode_target(
36+
_kind = runtime.python_library,
37+
name = "operators",
38+
srcs = glob([
39+
"operators/*.py",
40+
]),
41+
deps = [
42+
":serialization",
43+
":utils",
44+
"//executorch/backends/transforms:lib",
45+
],
46+
)
47+
48+
fbcode_target(
49+
_kind = runtime.python_library,
50+
name = "partitioner",
51+
srcs = glob([
52+
"partition/*.py",
53+
]),
54+
visibility = ["PUBLIC"],
55+
deps = [
56+
":backend",
57+
"//caffe2:torch",
58+
"//executorch/exir/backend:compile_spec_schema",
59+
"//executorch/exir/backend:partitioner",
60+
"//executorch/exir/backend/canonical_partitioners:canonical_partitioner_lib",
61+
],
62+
)
63+
64+
fbcode_target(
65+
_kind = runtime.python_library,
66+
name = "serialization",
67+
srcs = glob([
68+
"serialization/*.py",
69+
]),
70+
resources = [
71+
"serialization/schema.fbs",
72+
],
73+
)
74+
75+
fbcode_target(
76+
_kind = runtime.python_library,
77+
name = "utils",
78+
srcs = glob([
79+
"utils/*.py",
80+
]),
81+
deps = [
82+
":serialization",
83+
"//caffe2:torch",
84+
"//executorch/exir:lib",
85+
],
86+
)
87+
88+
fbcode_target(
89+
_kind = runtime.python_test,
90+
name = "test",
91+
srcs = glob([
92+
"test/*.py",
93+
]),
94+
deps = [
95+
":backend",
96+
":partitioner",
97+
"//caffe2:torch",
98+
"//executorch/examples/models:models",
99+
"//executorch/exir/tests:models",
100+
"//executorch/extension/export_util:export_util",
101+
"//executorch/devtools:lib",
102+
"//executorch/devtools/bundled_program/serialize:lib",
103+
"fbsource//third-party/pypi/pytest:pytest",
104+
],
17105
)

‎backends/apple/mps/TARGETS‎

Lines changed: 0 additions & 98 deletions
This file was deleted.

‎backends/xnnpack/serialization/BUCK‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,32 @@
1+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target")
2+
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
13
load(":targets.bzl", "define_common_targets")
24

5+
oncall("executorch")
6+
37
define_common_targets()
8+
9+
fbcode_target(
10+
_kind = runtime.python_library,
11+
name = "xnnpack_schema",
12+
srcs = [
13+
"xnnpack_graph_schema.py",
14+
],
15+
visibility = ["PUBLIC"],
16+
)
17+
18+
fbcode_target(
19+
_kind = runtime.python_library,
20+
name = "xnnpack_serializer",
21+
srcs = [
22+
"xnnpack_graph_serialize.py",
23+
],
24+
resources = [
25+
"schema.fbs",
26+
],
27+
visibility = ["PUBLIC"],
28+
deps = [
29+
":xnnpack_schema",
30+
"//executorch/exir/_serialize:lib",
31+
],
32+
)

‎backends/xnnpack/serialization/TARGETS‎

Lines changed: 0 additions & 29 deletions
This file was deleted.

‎devtools/bundled_program/BUCK‎

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,48 @@
1+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target")
2+
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
13
load(":targets.bzl", "define_common_targets")
24

35
oncall("executorch")
46

57
define_common_targets()
8+
9+
fbcode_target(
10+
_kind = runtime.python_library,
11+
name = "core",
12+
srcs = [
13+
"core.py",
14+
],
15+
visibility = ["PUBLIC"],
16+
deps = [
17+
":config",
18+
":version",
19+
"//caffe2:torch",
20+
"//executorch/devtools/bundled_program/schema:bundled_program_schema_py",
21+
"//executorch/exir:schema",
22+
"//executorch/exir:tensor",
23+
],
24+
)
25+
26+
fbcode_target(
27+
_kind = runtime.python_library,
28+
name = "config",
29+
srcs = [
30+
"config.py",
31+
],
32+
visibility = ["PUBLIC"],
33+
deps = [
34+
"fbsource//third-party/pypi/typing-extensions:typing-extensions",
35+
"//caffe2:torch",
36+
],
37+
)
38+
39+
fbcode_target(
40+
_kind = runtime.python_library,
41+
name = "version",
42+
srcs = [
43+
"version.py",
44+
],
45+
visibility = [
46+
"//executorch/devtools/...",
47+
],
48+
)

‎devtools/bundled_program/TARGETS‎

Lines changed: 0 additions & 44 deletions
This file was deleted.

‎devtools/bundled_program/schema/BUCK‎

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,26 @@
11
# Any targets that should be shared between fbcode and xplat must be defined in
2-
# targets.bzl. This file can contain xplat-only targets.
2+
# targets.bzl. This file can contain fbcode-only targets.
33

4+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target")
5+
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
46
load(":targets.bzl", "define_common_targets")
57

68
oncall("executorch")
79

810
define_common_targets()
11+
12+
fbcode_target(
13+
_kind = runtime.python_library,
14+
name = "bundled_program_schema_py",
15+
srcs = [
16+
"__init__.py",
17+
"bundled_program_schema.py",
18+
],
19+
visibility = [
20+
"//executorch/devtools/bundled_program/...",
21+
"//executorch/devtools/etrecord/...",
22+
],
23+
deps = [
24+
"//executorch/exir:scalar_type",
25+
],
26+
)

0 commit comments

Comments
 (0)