Skip to content

Commit 5f58949

Browse files
committed
✨ Integrate gflags library into build configuration
1 parent 9752cc6 commit 5f58949

File tree

6 files changed

+2
-17
lines changed

6 files changed

+2
-17
lines changed

CMakeLists.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -455,14 +455,6 @@ endif()
455455

456456
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/configurations)
457457

458-
#
459-
# gflags: Commandline flag host library.
460-
#
461-
462-
if(EXECUTORCH_BUILD_GFLAGS)
463-
add_subdirectory(third-party/gflags)
464-
endif()
465-
466458
# Install `executorch` library as well as `executorch-config.cmake` under
467459
# ${CMAKE_INSTALL_PREFIX}/
468460
install(

backends/apple/coreml/scripts/build_tests.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ cmake "$EXECUTORCH_ROOT_PATH" -B"$CMAKE_EXECUTORCH_BUILD_DIR_PATH" \
3333
-DPLATFORM=MAC_UNIVERSAL \
3434
-DDEPLOYMENT_TARGET=13.0 \
3535
-DEXECUTORCH_BUILD_EXECUTOR_RUNNER=OFF \
36-
-DEXECUTORCH_BUILD_XNNPACK=OFF \
37-
-DEXECUTORCH_BUILD_GFLAGS=OFF
36+
-DEXECUTORCH_BUILD_XNNPACK=OFF
3837

3938
cmake --build "$CMAKE_EXECUTORCH_BUILD_DIR_PATH" -j9 -t executorch
4039

backends/cadence/build_cadence_fusionG3.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ if $STEPWISE_BUILD; then
5050
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=OFF \
5151
-DPYTHON_EXECUTABLE=python3 \
5252
-DEXECUTORCH_FUSION_G3_OPT=ON \
53-
-DEXECUTORCH_BUILD_GFLAGS=ON \
5453
-DHAVE_FNMATCH_H=OFF \
5554
-Bcmake-out/backends/cadence \
5655
backends/cadence

backends/cadence/build_cadence_hifi4.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ if $STEPWISE_BUILD; then
4949
-DEXECUTORCH_BUILD_KERNELS_CUSTOM=OFF \
5050
-DPYTHON_EXECUTABLE=python3 \
5151
-DEXECUTORCH_NNLIB_OPT=ON \
52-
-DEXECUTORCH_BUILD_GFLAGS=ON \
5352
-DHAVE_FNMATCH_H=OFF \
5453
-Bcmake-out/backends/cadence \
5554
backends/cadence

third-party/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
# LICENSE file in the root directory of this source tree.
66

77
add_subdirectory(json)
8+
add_subdirectory(gflags)
89

910
if(EXECUTORCH_BUILD_PYBIND)
1011
add_subdirectory(pybind11)

tools/cmake/preset/default.cmake

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,6 @@ define_overridable_option(
209209
"Build the Cortex-M backend"
210210
BOOL OFF
211211
)
212-
define_overridable_option(
213-
EXECUTORCH_BUILD_GFLAGS
214-
"Build the gflags library."
215-
BOOL ON
216-
)
217212
define_overridable_option(
218213
EXECUTORCH_COREML_BUILD_EXECUTOR_RUNNER
219214
"Build CoreML executor runner."

0 commit comments

Comments
 (0)