Repository navigation
Commit 580d9bc
committed
Qualcomm AI Engine Direct - Order only the passes that run
On HTP, the pass manager runs TagPositionalSinCos after every other
pass but the terminal ones, like ResolveDebugHandle, whatever dep_table
says, through _get_fixed_passes_dependency. It built that order from
every pass in passes_job, including the ones turned off. So with
TagPositionalSinCos turned off the documented way, a dep_table that
orders another pass after it still failed:
passes_job[TagPositionalSinCos][QCOM_PASS_ACTIVATE_KEY] = False
dep_table = {RemoveRedundancy: [TagPositionalSinCos]}
# RuntimeError: Circular dependency detected
A pass that is turned off does not run, so the fixed order is now built
from the active passes only. A new test turns TagPositionalSinCos off
with such a dep_table and checks that the passes build, without it and
with ResolveDebugHandle last. It fails without this change.1 parent 3f181d3 commit 580d9bc
3 files changed
Lines changed: 30 additions & 5 deletions
File tree
- backends/qualcomm
- _passes
- backends/htp
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
| 44 | + | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
414 | | - | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
415 | 422 | | |
416 | 423 | | |
417 | 424 | | |
| |||
440 | 447 | | |
441 | 448 | | |
442 | 449 | | |
443 | | - | |
444 | | - | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
445 | 453 | | |
446 | 454 | | |
447 | 455 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3441 | 3441 | | |
3442 | 3442 | | |
3443 | 3443 | | |
| 3444 | + | |
| 3445 | + | |
| 3446 | + | |
| 3447 | + | |
| 3448 | + | |
| 3449 | + | |
| 3450 | + | |
| 3451 | + | |
| 3452 | + | |
| 3453 | + | |
| 3454 | + | |
| 3455 | + | |
| 3456 | + | |
| 3457 | + | |
| 3458 | + | |
| 3459 | + | |
| 3460 | + | |
3444 | 3461 | | |
3445 | 3462 | | |
3446 | 3463 | | |
| |||
0 commit comments