Created command to sync active subscriptions

Part of #4764

Author: renzon

pythonpro/core/tests/test_view_unsubscribe.py

@@ -2,4 +2,4 @@
 
 
 def test_status_code(client):
-    return client.get(reverse('core:unsubscribe'))
+    assert client.get(reverse('core:unsubscribe'))

pythonpro/discourse/tests/test_sso.py

@@ -120,15 +120,15 @@ def test_redirect_payload_lead_data(logged_user, nonce, response_with_lead):
 )
 def test_status_invalid_data(client_with_member, invalid_data):
     response = client_with_member.get(reverse('discourse:sso'), data=invalid_data)
-    return response.status_code == 400
+    assert response.status_code == 400
 
 
 def test_payload_without_nonce(response_without_nonce):
-    return response_without_nonce.status_code == 400
+    assert response_without_nonce.status_code == 400
 
 
 def test_payload_with_mismatch_signature(response_with_wrong_sig):
-    return response_with_wrong_sig.status_code == 400
+    assert response_with_wrong_sig.status_code == 400
 
 
 def test_user_not_logged_status_code(client):

pythonpro/memberkit/api.py

@@ -45,12 +45,14 @@ def _configure_api_key(func, *args, api_key=_ApiKeyNone, **kwargs):
 @_configure_api_key
 def list_membership_levels(*, api_key=_ApiKeyNone):
     response = requests.get(f'{_base_url}/api/v1/membership_levels?api_key={api_key}')
+    response.raise_for_status()
     return response.json()
 
 
 @_configure_api_key
 def user_detail(email_or_memberkit_user_id, *, api_key=_ApiKeyNone):
     response = requests.get(f'{_base_url}/api/v1/users/{email_or_memberkit_user_id}?api_key={api_key}')
+    response.raise_for_status()
     return response.json()
 
 
@@ -73,11 +75,13 @@ def activate_user(full_name: str, email: str, subscription_type_id: int, expires
 
 
 @_configure_api_key
-def update_user_subscription(memberkit_user_id: int, subscription_type_id: int, status: str, expires_at: date = None, *,
+def update_user_subscription(memberkit_user_id: int, subscription_type_id: int, status: str, expires_at: date, *,
                              api_key=_ApiKeyNone):
+    valid_statuses = {'inactive', 'pending', 'active', 'expired'}
+    if status not in valid_statuses:
+        raise ValueError(f'{status} is not on of valid statuses: {valid_statuses}')
+
     user_json = user_detail(memberkit_user_id, api_key=api_key)
-    if expires_at is None:
-        expires_at = date(2200, 1, 1)
     data = {
         'full_name': user_json['full_name'],
         'email': user_json['email'],
@@ -88,6 +92,7 @@ def update_user_subscription(memberkit_user_id: int, subscription_type_id: int,
         'expires_at': expires_at.strftime('%d/%m/%Y'),
     }
     response = requests.post(f'{_base_url}/api/v1/users?api_key={api_key}', json=data)
+    response.raise_for_status()
     return response.json()
 
 
@@ -105,13 +110,15 @@ def inactivate_user(memberkit_user_id: int, subscription_type_id: int, *,
         'expires_at': date.today().strftime('%d/%m/%Y'),
     }
     response = requests.post(f'{_base_url}/api/v1/users?api_key={api_key}', json=data)
+    response.raise_for_status()
     return response.json()
 
 
 @_configure_api_key
 def delete_user(memberkit_user_id: int, *, api_key=_ApiKeyNone):
     response = requests.delete(f'{_base_url}/api/v1/users/{memberkit_user_id}?api_key={api_key}')
     response.raise_for_status()
+    return response
 
 
 @_configure_api_key

pythonpro/memberkit/facade.py

@@ -1,11 +1,12 @@
 from builtins import Exception
-from datetime import timedelta
 from itertools import count
 from logging import Logger
 from typing import List
 
 from celery import shared_task
+from django.db import transaction
 from django.utils import timezone
+from requests import HTTPError
 
 from pythonpro.memberkit import api
 from pythonpro.memberkit.models import SubscriptionType, Subscription, YEAR_IN_DAYS, UserSubscriptionsSummary
@@ -62,25 +63,34 @@ def create_new_subscription(payment, observation: str = '') -> Subscription:
 
 def activate(subscription, responsible=None, observation=''):
     user = subscription.subscriber
-    if subscription.status == Subscription.Status.INACTIVE or subscription.activated_at is None:
+    if subscription.activated_at is None:
+        # Faz extensão da anualidade se for a primeira ativação
         subscription.activated_at = timezone.now()
-    for subscription_type in subscription.subscription_types.all():
-        expires_at = subscription.activated_at + timedelta(days=subscription_type.days_of_access)
-        if subscription_type.id in IDS_COMUNIDADE_SUBSCRIPTION:
-            active_comunidade_subscriptions = Subscription.objects.filter(
-                subscriber_id=user.id,
-                status=Subscription.Status.ACTIVE,
-                subscription_types__in=IDS_COMUNIDADE_SUBSCRIPTION
-            )
+        for subscription_type in subscription.subscription_types.all():
+            if subscription_type.id in IDS_COMUNIDADE_SUBSCRIPTION:
+                active_comunidade_subscriptions = Subscription.objects.filter(
+                    subscriber_id=user.id,
+                    status=Subscription.Status.ACTIVE,
+                    subscription_types__in=IDS_COMUNIDADE_SUBSCRIPTION
+                )
 
-            max_remaining_days = max(s.remaining_days for s in active_comunidade_subscriptions)
-            expires_at += timedelta(days=max_remaining_days)
-            subscription.days_of_access += max_remaining_days
+                max_remaining_days = max(
+                    (s.remaining_days for s in active_comunidade_subscriptions),
+                    default=0
+                )
+                subscription.days_of_access += max_remaining_days
 
-        response_json = api.activate_user(
-            user.get_full_name(), user.email, subscription_type.id, expires_at
-        )
-    subscription.memberkit_user_id = response_json['id']
+            response_json = api.activate_user(
+                user.get_full_name(), user.email, subscription_type.id, subscription.expires_at
+            )
+        subscription.memberkit_user_id = response_json['id']
+    else:
+        # Se for a segunda, só usa os dados já calculados
+        for subscription_type in subscription.subscription_types.all():
+            response_json = api.activate_user(
+                user.get_full_name(), user.email, subscription_type.id, subscription.expires_at
+            )
+        subscription.memberkit_user_id = response_json['id']
     subscription.status = Subscription.Status.ACTIVE
     if subscription.observation:
         subscription.observation += f'\n\n {observation}'
@@ -96,15 +106,14 @@ def inactivate(subscription, responsible=None, observation=''):
     for subscription_type in subscription.subscription_types.all().only('id'):
         api.inactivate_user(subscription.memberkit_user_id, subscription_type.id)
     subscription.status = Subscription.Status.INACTIVE
-    subscription.activated_at = None
     if responsible is not None:
         subscription.responsible = responsible
     if subscription.observation:
         subscription.observation += f'\n\n {observation}'
     else:
         subscription.observation = observation
     subscription.save(update_fields=[
-        'status', 'activated_at', 'responsible', 'observation'
+        'status', 'responsible', 'observation'
     ])
     return subscription
 
@@ -169,25 +178,37 @@ def process_expired_subscriptions(user_id):
     for subscription in active_subscriptions:
         if subscription.expires_at < now:
             subscription.status = Subscription.Status.INACTIVE
-            subscription.save()
     inactive_subscriptions = [s for s in active_subscriptions if s.status == Subscription.Status.INACTIVE]
     active_subscriptions = [s for s in active_subscriptions if s.status == Subscription.Status.ACTIVE]
     if len(active_subscriptions) == 0:
         for memberkit_user_id in summary.memberkit_user_ids():
             _logger.info(f'Deleted memberkit account for user_id: {user_id}')
-            api.delete_user(memberkit_user_id)
+            try:
+                api.delete_user(memberkit_user_id)
+            except HTTPError as e:
+                if e.response.status_code != 404:
+                    raise e
+
+        with transaction.atomic():
+            for subscription in inactive_subscriptions:
+                subscription.save()
     else:
-        for inactive_subscription in inactive_subscriptions:
-            _logger.info(f'Inactivated {inactive_subscription.name} for user_id: {user_id}')
-            inactivate(inactive_subscription, observation='Inativada por processo de inativação')
         for active_subscription in active_subscriptions:
-            for subscription_type in active_subscription.subscription_types.all().only('id'):
+            for subscription_type_id in active_subscription.subscription_types.all().values_list('id', flat=True):
                 _logger.info(f'Activated {active_subscription.name} for user_id: {user_id}')
                 api.update_user_subscription(
                     active_subscription.memberkit_user_id,
-                    subscription_type,
-                    'activate'
+                    subscription_type_id,
+                    'active',
+                    active_subscription.expires_at.date()
                 )
+        for inactive_subscription in inactive_subscriptions:
+            _logger.info(f'Inactivated {inactive_subscription.name} for user_id: {user_id}')
+            try:
+                inactivate(inactive_subscription, observation='Inativada por data de experição7')
+            except HTTPError as e:
+                if e.response.status_code != 404:
+                    raise e
 
 
 def inactivate_expired_subscriptions():