ci: refactor docker builds

Author: pythoninthegrass

.github/workflows/docker.yml

@@ -32,6 +32,7 @@ jobs:
     name: Push Docker image to container registry
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: true
       matrix:
         dockerfile: [Dockerfile]
     concurrency:
@@ -44,7 +45,7 @@ jobs:
       actions: read
       id-token: write
     steps:
-      - name: Check out the repo
+      - name: Checkout code
         uses: actions/checkout@v4
 
       - name: Set password by container registry
@@ -53,12 +54,6 @@ jobs:
             "ghcr.io")
               echo "REGISTRY_PASS=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
               ;;
-            "*.dkr.ecr.*.amazonaws.com")
-              echo "Using AWS ECR - will authenticate in a separate step" >> $GITHUB_STEP_SUMMARY
-              ;;
-            "gcr.io")
-              echo "Using GCR - will authenticate in a separate step" >> $GITHUB_STEP_SUMMARY
-              ;;
             *)
               if [ -n "${{ secrets.REGISTRY_PASS }}" ]; then
                 echo "REGISTRY_PASS=${{ secrets.REGISTRY_PASS }}" >> $GITHUB_ENV
@@ -69,67 +64,53 @@ jobs:
               ;;
           esac
 
-      - name: Configure AWS Credentials
-        if: contains(env.REGISTRY_URL, '.dkr.ecr.')
-        uses: aws-actions/configure-aws-credentials@v4
-        with:
-          role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
-          aws-region: ${{ secrets.AWS_REGION }}
-
-      - name: Login to Amazon ECR
-        if: contains(env.REGISTRY_URL, '.dkr.ecr.')
-        id: login-ecr
-        uses: aws-actions/amazon-ecr-login@v2
-
-      - name: Authenticate to Google Cloud
-        if: env.REGISTRY_URL == 'gcr.io'
-        uses: google-github-actions/auth@v2
-        with:
-          credentials_json: ${{ secrets.GCP_SA_KEY }}
-
       - name: Log into container registry
-        if: >
-          env.REGISTRY_URL != '*.dkr.ecr.*.amazonaws.com'
-          && env.REGISTRY_URL != 'gcr.io'
+        if: github.event_name != 'pull_request'
         uses: docker/login-action@v3
         with:
           registry: ${{ env.REGISTRY_URL }}
           username: ${{ env.REGISTRY_USER }}
           password: ${{ env.REGISTRY_PASS }}
 
-      - name: Extract image name from Dockerfile
+      - name: Set image name
         id: image_name
         run: |
-          IMAGE=$(grep "LABEL org.opencontainers.image.title" ${{ matrix.dockerfile }} | cut -d'"' -f2)
+          if [ -n "${{ env.IMAGE }}" ]; then
+            IMAGE="${{ env.IMAGE }}"
+          else
+            IMAGE=$(grep "LABEL org.opencontainers.image.title" Dockerfile | cut -d'"' -f2)
+          fi
           echo "IMAGE=$IMAGE" >> $GITHUB_OUTPUT
+          echo "IMAGE=$IMAGE" >> $GITHUB_ENV
 
-      - name: Extract metadata (tags, labels) for Docker
+      - name: Docker meta
         id: meta
         uses: docker/metadata-action@v5
         with:
           images: |
             ${{ env.REGISTRY_URL }}/${{ env.REGISTRY_USER }}/${{ steps.image_name.outputs.IMAGE }}
           tags: |
-            type=raw,value=latest,enable=${{ endsWith(github.ref, 'main') || endsWith(github.ref, 'master') }}
-            type=ref,event=branch,enable=${{ !endsWith(github.ref, 'main') && !endsWith(github.ref, 'master') }}
+            type=schedule
+            type=ref,event=branch
+            type=ref,event=pr
             type=semver,pattern={{version}}
-          flavor: |
-            latest=false
+            type=semver,pattern={{major}}.{{minor}}
+            type=semver,pattern={{major}}
+            type=sha
+            type=raw,value=latest,enable={{is_default_branch}}
 
-      - name: Set up QEMU
+      - name: Setup QEMU
         uses: docker/setup-qemu-action@v3
 
-      - name: Set up Docker Buildx
+      - name: Setup Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Build and push Docker image
+      - name: Build and push
         uses: docker/build-push-action@v6
         with:
           context: .
           file: ./${{ matrix.dockerfile }}
-          push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
-          platforms: linux/amd64,linux/arm64/v8
-          cache-from: type=registry,ref=${{ steps.meta.outputs.tags }}
-          cache-to: type=registry,ref=${{ steps.meta.outputs.tags }},mode=max
+          cache-from: type=registry,ref=${{ env.REGISTRY_URL }}/${{ env.REGISTRY_USER }}/${{ steps.image_name.outputs.IMAGE }}:buildcache
+          cache-to: type=registry,ref=${{ env.REGISTRY_URL }}/${{ env.REGISTRY_USER }}/${{ steps.image_name.outputs.IMAGE }}:buildcache,mode=max