Skip to content

Commit a959a02

Browse files
committed
Apply suggestion from @DragonMoffon in height.setter
1 parent 1e8d23c commit a959a02

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

arcade/sprite/base.py

+11-8
Original file line numberDiff line numberDiff line change
@@ -197,15 +197,18 @@ def height(self) -> float:
197197
@height.setter
198198
def height(self, new_value: float):
199199
size = self._size
200-
if new_value != size[1]:
201-
new_scale = Vec2(self._scale[0], new_value / self._texture.height)
202-
self._scale = new_scale
203-
self._hit_box.scale = new_scale
204-
self._size = Vec2(size[0], new_value)
205200

206-
self.update_spatial_hash()
207-
for sprite_list in self.sprite_lists:
208-
sprite_list._update_height(self)
201+
if new_value == size[1]:
202+
return
203+
204+
new_scale = Vec2(self._scale[0], new_value / self._texture.height)
205+
self._scale = new_scale
206+
self._hit_box.scale = new_scale
207+
self._size = Vec2(size[0], new_value)
208+
209+
self.update_spatial_hash()
210+
for sprite_list in self.sprite_lists:
211+
sprite_list._update_height(self)
209212

210213
@property
211214
def size(self) -> Vec2:

0 commit comments

Comments
 (0)