-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: specify resolve
for user-defined benchmarks.
#138
Comments
You can add a "version" field to the There is a mechanism available. A benchmark can inherit metadata through the "inherits" field in the For example, set "inherits: .." and that benchmark will inherit metadata from ../base.toml. (See https://github.com/pyston/python-macrobenchmarks for an example.) Then you could set the version in that one file. IIRC I added support for a couple other cases. In fact, you should be able to inherit from the top-level project's pyproject.toml. (I didn't test that machinery very thoroughly, so there may be bugs.) |
Thanks @ericsnowcurrently! The However I do spot an issue that blocks the usage of |
I'm closing this for the original question has been answered, the broken |
pyperformance itself uses
resolve_default_benchmark
to set version of every benchmark to the version of the package.For other projects who want to define their own benchmarks, this could also be helpful, so such projects don't need to update the version field every time, however, I didn't find any mechanism that can be used for that.
Looking forward to your opinions.
The text was updated successfully, but these errors were encountered: