initial pass at salt-lint for files changed in commits (#263)

* initial pass at salt-lint for files changed in commits

* python version needs to be in quotes

* filter linter to only look at .sls files

* fix one of two linting errors in pillar/base/users.sls, leave second to trip a CI failure for linting

* add a configuration file for salt-lint

* fix second of two linting errors in pillar/base/users.sls

Author: ewdurbin

.github/workflows/lint.yml

@@ -0,0 +1,35 @@
+name: Lint
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  salt-lint:
+    name: Salt Lint
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    - name: Setup Python
+      uses: actions/setup-python@v4
+      with:
+        python-version: "3.10"
+
+    - name: Install tox and any other packages
+      run: pip install tox
+
+    - id: files
+      name: Determine changed files
+      uses: jitterbit/get-changed-files@v1
+      with:
+        format: json
+
+    - name: Run Linter
+      run: tox -e lint -- $(jq -r '.[] | select(. | endswith(".sls"))' <<< '${{ steps.files.outputs.added_modified }}' | xargs)

.salt-lint

@@ -0,0 +1,3 @@
+---
+skip_list:
+  - 204

pillar/base/users.sls

@@ -275,7 +275,7 @@ users:
     accesss:
       codespeed:
         allowed: True
-        sudo: True    
+        sudo: True
 
   jafo:
     fullname: "Sean Reifschneider"
@@ -444,7 +444,7 @@ users:
         sudo: True
         allowed: True
         groups:
-          - roundup    
+          - roundup
 
   lemburg:
     fullname: "Marc-Andre Lemburg"

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = docs
+envlist = docs, lint
 skipsdist = true
 
 [testenv:docs]
@@ -9,3 +9,10 @@ deps =
 basepython = python3
 commands =
     sphinx-build -W -b html -d {envtmpdir}/doctrees docs docs/_build/html
+
+[testenv:lint]
+deps =
+    salt-lint
+basepython = python3
+commands =
+    salt-lint {posargs:salt/top.sls}