Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-necessary socket requirements in pdb async tests #128265

Closed
graingert opened this issue Dec 25, 2024 · 0 comments
Closed

Remove un-necessary socket requirements in pdb async tests #128265

graingert opened this issue Dec 25, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir

Comments

@graingert
Copy link
Contributor

graingert commented Dec 25, 2024 •
edited by bedevere-app bot
Loading

Proposal:

the pdb async tests should run coroutines using coro.send(None) because they don't need an async framework to run. This would remove asyncio from the tests and support running on emscripten/wasi

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@graingert graingert added type-feature A feature request or enhancement and removed type-feature A feature request or enhancement labels Dec 25, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 25, 2024
Merged
@picnixz picnixz added the tests Tests in the Lib/test dir label Dec 25, 2024
Eclips4 pushed a commit that referenced this issue Dec 28, 2024
@graingert
gh-128265: Support WASI/Emscripten on PDB tests, by removing asyncio …
aab51c3 
…from pdb tests (#128264)

A part of `Lib/test/test_pdb.py` was previously unable to run on WASI/Emscripten
platforms because it lacked support for `asyncio`.
In fact, these tests could be rewritten without the `asyncio` framework because 
`test_pdb` tests the behavior of coroutines, which are not part of `asyncio`.

Now reliance on the availability of `asyncio` has been removed and
part of `test_pdb` that deals with coroutines working on WASI/Emscripten platforms.
@Eclips4 Eclips4 closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graingert @picnixz @Eclips4