Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant specific package plugins #413

Closed
shubhbapna opened this issue Sep 13, 2024 · 2 comments
Closed

Variant specific package plugins #413

shubhbapna opened this issue Sep 13, 2024 · 2 comments

Comments

@shubhbapna
Copy link
Collaborator

Is it possible to have package plugins specific to a variant instead of using if ctx.variant.startswith("varinat") everywhere in plugin code

@tiran
Copy link
Collaborator

tiran commented Sep 13, 2024

One idea is to check for a function with normalized variant name as suffix, e.g. first look for prepare_source_cuda, then for prepare_source, and then fall back to default_prepare_source.

@dhellmann
Copy link
Member

We could do this, but I think it will make configuration of the plugins more complex for users. I'm going to close the ticket, but if we find a definite use case where it solves an issue in the future we can revisit the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants