Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip-audit to poetry operations that touch the lockfile #6220

Closed
2 tasks done
tigerhawkvok opened this issue Aug 23, 2022 · 4 comments
Closed
2 tasks done

Add pip-audit to poetry operations that touch the lockfile #6220

tigerhawkvok opened this issue Aug 23, 2022 · 4 comments
Labels
kind/feature Feature requests/implementations

Comments

@tigerhawkvok
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

Adding a tool like pip-audit to operations that touch the lockfile adds a measure of security to Poetry. Poetry knows the source of the files and can, correctly, only inspect the dependencies that come directly from PyPI; and further, since Poetry stores hashes in the lockfile once a dependency is known safe it doesn't have to be checked again. This helps mitigate PyPI poisoning attacks.

Possibly if performance is an issue its functionality (and the state of "is it default") can be a global Poetry config flag.

@tigerhawkvok tigerhawkvok added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Aug 23, 2022
@dimbleby
Copy link
Contributor

Way out of scope IMO. If you like pip-audit, run pip-audit!

@finswimmer
Copy link
Member

Hey @tigerhawkvok,

this is definitely something out of scope for Poetry. Maybe it's possible that somebody will provide a plugin in the future.

fin swimmer

@finswimmer finswimmer added wontfix and removed status/triage This issue needs to be triaged labels Aug 23, 2022
@severo
Copy link

severo commented Nov 24, 2022

Related issue on pip-audit: pypa/pip-audit#84. They suggest adding poetry audit

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

4 participants