Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT support #66

Open
avara1986 opened this issue Nov 30, 2019 · 7 comments
Open

JWT support #66

avara1986 opened this issue Nov 30, 2019 · 7 comments
Labels
feature New feature in progres help wanted Extra attention is needed

Comments

@avara1986
Copy link
Member

Create a service to support JWT like https://github.com/python-microservices/oauth

@avara1986 avara1986 added help wanted Extra attention is needed Improvement Not a bug but... could be better labels Nov 30, 2019
@KingDarBoja
Copy link
Contributor

Hello, just curious, I was checking the provided oauth microservice and I do see you guys are using flask-jwt. But wouldn't be better to use other library for jwt which has better maintenance and is up-to-date like as pyjwt as example?

Cheers!

@avara1986
Copy link
Member Author

avara1986 commented Dec 18, 2019

Hi @KingDarBoja! Thanks for your recommendation! 👍 We create the oauth MS with flask-jwt because it works with PyJWT, but we don't saw that flask-jwt has no maintenance. If someone want to create this service could be like # 62: The metrics with prometheus in python has got libraries with flask implementation with no maintenance and we create a similar implementation like these

@KingDarBoja
Copy link
Contributor

I am interested on such thing but need some time to know more about this project along with its dependencies. Is there any gitter where you guys chatting and also answer question for newcomers?

@avara1986
Copy link
Member Author

Is there any gitter where you guys chatting and also answer question for newcomers?

No, but it's good idea 😄 See #80

@avara1986 avara1986 added feature New feature in progres and removed Improvement Not a bug but... could be better labels Jan 21, 2020
@DiptoChakrabarty
Copy link
Contributor

DiptoChakrabarty commented Oct 14, 2020

hey I am interested to know about this issue, can we use flask-jwt or flask-jwt-extended for this service

@DiptoChakrabarty
Copy link
Contributor

Hey can I work on this , I think we can use flask jwt extended which is relatively much better maintained and up-to date compared to flask-jwt . I would like to send the PR in the oauth micro service repository

@avara1986
Copy link
Member Author

It's a great Idea @DiptoChakrabarty :) Flask JWT Extended is more mantained than Flask JWT! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature in progres help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants